Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development #1879

Merged
merged 87 commits into from
Oct 25, 2023
Merged

Development #1879

merged 87 commits into from
Oct 25, 2023

Conversation

mghenciu and others added 26 commits September 1, 2023 10:55
Bumps [php-stubs/acf-pro-stubs](https://github.com/php-stubs/acf-pro-stubs) from 6.0.6 to 6.1.7.
- [Release notes](https://github.com/php-stubs/acf-pro-stubs/releases)
- [Commits](php-stubs/acf-pro-stubs@v6.0.6...v6.1.7)

---
updated-dependencies:
- dependency-name: php-stubs/acf-pro-stubs
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [php-stubs/woocommerce-stubs](https://github.com/php-stubs/woocommerce-stubs) from 7.9.0 to 8.0.1.
- [Commits](php-stubs/woocommerce-stubs@v7.9.0...v8.0.1)

---
updated-dependencies:
- dependency-name: php-stubs/woocommerce-stubs
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Remove unnecessary deps when using widgets
…t/php-stubs/acf-pro-stubs-6.1.7

chore(deps-dev): bump php-stubs/acf-pro-stubs from 6.0.6 to 6.1.7
…t/php-stubs/woocommerce-stubs-8.0.1

chore(deps-dev): bump php-stubs/woocommerce-stubs from 7.9.0 to 8.0.1
@HardeepAsrani HardeepAsrani marked this pull request as ready for review September 25, 2023 08:32
@pirate-bot
Copy link
Contributor

pirate-bot commented Sep 25, 2023

Plugin build for 95ea4a0 is ready 🛎️!

@pirate-bot
Copy link
Contributor

pirate-bot commented Sep 25, 2023

Bundle Size Diff

Package Old Size New Size Diff
Animations 274.83 KB 275.01 KB 183 B (0.07%)
Blocks 1.47 MB 1.47 MB 1.45 KB (0.10%)
CSS 89.3 KB 89.3 KB 0 B (0.00%)
Dashboard 127.66 KB 132.27 KB 4.61 KB (3.61%)
Export Import 87.19 KB 87.21 KB 24 B (0.03%)
Pro 346.73 KB 346.54 KB -188 B (-0.05%)

@pirate-bot
Copy link
Contributor

pirate-bot commented Sep 25, 2023

E2E Summary

Typing

Test Average Time (ms) Standard Deviation (ms) Median Time (ms) Quantile for soft limit (%) Quantile for hard limit (%)
Typing 70.18 14.38 66.62 21.05 (60ms) 78.95 (80ms)
Values above 60ms "0 - 97.04, 3 - 71.20, 4 - 60.66, 6 - 64.55, 7 - 60.18, 8 - 63.54, 9 - 106.05, 10 - 72.28, 11 - 85.39, 12 - 68.09, 13 - 66.62, 14 - 76.16, 16 - 86.78, 17 - 73.07, 18 - 60.39"

@HardeepAsrani
Copy link
Member Author

@Codeinwp/qa-team Can we do a pre-release QA on this? We want to release this alongside with BF deals so it will be great to prioritize this if no other major release is being QA'd right now.

@irinelenache
Copy link
Contributor

irinelenache commented Oct 24, 2023

@HardeepAsrani

  • The live search style is broken when it's added in the Pop-up. The results are there but they are not visible https://vertis.d.pr/v/TpPjEA (I added this line do_action( 'otter_load_live_search_deps' ); in functions.php)
  • If i have both Otter and Neve installed, the priority for the global notice will go to Neve, but should the Otter notice be visible after the Neve one was dismissed? Right now that's not happening.
  • I had this issue when i added a default Maps block in the sidebar but i'm not able to reproduce it again, i'm posting it to make sure it's not related to something bigger
    LE: I see it happens on a fresh instance (with an imported demosite), after adding the default Maps block in the sidebar. When i open the inspector and delete the second px from the height attribute, it starts to work
  • The AI block is available only if you have the administrator role. If you use another role, the block will ask for an API key and it won't work even if the key is valid or not https://vertis.d.pr/v/jLdi3r

@rodica-andronache
Copy link

@irinelenache regarding the Maps issue, it's happening to me too, after importing a starter site. Where the maps block has a "400pxpx" height

@Soare-Robert-Daniel Soare-Robert-Daniel mentioned this pull request Oct 25, 2023
9 tasks
@Soare-Robert-Daniel
Copy link
Contributor

Soare-Robert-Daniel commented Oct 25, 2023

  • The live search style is broken when it's added in the Pop-up. The results are there but they are not visible https://vertis.d.pr/v/TpPjEA (I added this line do_action( 'otter_load_live_search_deps' ); in functions.php)

This will be made into a separate issue. The problem is more complex since the math calc in the popup does work differently. Not use if we can find a nice solution for this, but it should not be an important matter since the popup is not the ideal place for a post search.

  • If i have both Otter and Neve installed, the priority for the global notice will go to Neve, but should the Otter notice be visible after the Neve one was dismissed? Right now that's not happening.

This is the correct behavior.

  • I had this issue when i added a default Maps block in the sidebar but i'm not able to reproduce it again, i'm posting it to make sure it's not related to something bigger

Added a smarted checking 🔧 Also, @irinelenache can you tell me what startersites do this? Is it possible that it might be some wrong values?

  • The AI block is available only if you have the administrator role. If you use another role, the block will ask for an API key and it won't work even if the key is valid or not https://vertis.d.pr/v/jLdi3r

Now AI Block will be available to use for non-admin users. But the key must be already set.

@Soare-Robert-Daniel
Copy link
Contributor

@irinelenache you can find the fix here: #1928

@irinelenache
Copy link
Contributor

@Soare-Robert-Daniel
✔️ The AI block issue is fixed now

Added a smarted checking 🔧 Also, @irinelenache can you tell me what startersites do this? Is it possible that it might be some wrong values?

^ It happened using any starter site, i just changed the settings in order to make the sidebar visible and added the block. The PR did not fix this issue, you can check on this instance:

 Admin area URL: https://finalizeburst.s2-tastewp.com/wp-admin 
 Username: irinel 
 Password: R3ceDl322ys 

@Soare-Robert-Daniel
Copy link
Contributor

^ It happened using any starter site, i just changed the settings in order to make the sidebar visible and added the block. The PR did not fix this issue, you can check on this instance:

It seems that when loaded with customizer in the sidebar, the leaflet otter CSS is missing and the Leaflet might try to extract the height itself, thus creating the weird artifact like style="height: 400pxpx when we have to code that directly sets the height to the element.

This will be a separate issue.

@irinelenache
Copy link
Contributor

@Soare-Robert-Daniel @HardeepAsrani Thank you for checking & fixing the issues 🚀

Everything's fine regarding the release ✅

@HardeepAsrani HardeepAsrani merged commit 6967f6e into master Oct 25, 2023
11 of 12 checks passed
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 2.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants