Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extra condition check for upsell #1865

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Add extra condition check for upsell #1865

merged 1 commit into from
Sep 13, 2023

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Sep 12, 2023 •
edited
Loading

Closes #1679

Summary

Add extra conditional checks for upsell for:

  • Notice
  • Get Otter Pro label

Screenshots

Before

image

After

image

Test instructions

⚠️ You will need a multisite and make the Upsell notice appear.

When you switch to the current build, the notice and the label Get Otter Pro should disappear.

ℹ️ The following message is a part of the Themeisle SDK and is not subject to this PR.

image

Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review September 12, 2023 10:54
@pirate-bot
Copy link
Contributor

Bundle Size Diff

Package Old Size New Size Diff
Animations 270.81 KB 270.81 KB 0 B (0.00%)
Blocks 1.42 MB 1.42 MB 0 B (0.00%)
CSS 85.28 KB 85.28 KB 0 B (0.00%)
Dashboard 122.49 KB 122.49 KB 0 B (0.00%)
Export Import 83.17 KB 83.17 KB 0 B (0.00%)
Pro 303.34 KB 303.34 KB 0 B (0.00%)

@pirate-bot
Copy link
Contributor

Plugin build for 9649026 is ready 🛎️!

@pirate-bot
Copy link
Contributor

E2E Summary

Typing

Test Average Time (ms) Standard Deviation (ms) Median Time (ms) Quantile for soft limit (%) Quantile for hard limit (%)
Typing 53.62 4.29 53.49 89.47 (60ms) 100 (80ms)
Values above 60ms "13 - 64.10, 16 - 62.89"

@irinelenache
Copy link
Contributor

@Soare-Robert-Daniel Tested and the issue is fixed now 🚀

@HardeepAsrani HardeepAsrani merged commit afd2ede into development Sep 13, 2023
29 checks passed
@HardeepAsrani HardeepAsrani deleted the fix/upsell-notice branch September 13, 2023 10:43
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 2.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added released Indicate that an issue has been resolved and released in a particular version of the product. pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) labels Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HardeepAsrani HardeepAsrani HardeepAsrani approved these changes

Assignees
No one assigned
Labels
pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Soare-Robert-Daniel @pirate-bot @irinelenache @HardeepAsrani