Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Otter options infinite loading #1845

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Sep 1, 2023

Closes #1812

Summary

The current handling of the case for the user who did not have the right to write to modify the options was very minimal.

🔧 Add conditional statements that hide the options from which the users do not have permission.

Screenshots

Unauthorized users will see only the Onboarding modal and Feedback.

image


Test instructions

  1. Enter as a non-administrator user.
  2. Create a new post and check the otter options in the top-right corner.
  3. You should see only the onboarding Modal and Feedback.

⚠️ If you make a particular user with the rights to modify WP Options (like admin), then you should see the full options.


Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Sep 1, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review September 1, 2023 12:41
@pirate-bot
Copy link
Contributor

Bundle Size Diff

Package Old Size New Size Diff
Animations 270.81 KB 270.81 KB 0 B (0.00%)
Blocks 1.42 MB 1.42 MB 53 B (0.00%)
CSS 85.28 KB 85.28 KB 0 B (0.00%)
Dashboard 122.49 KB 122.49 KB 0 B (0.00%)
Export Import 83.17 KB 83.17 KB 0 B (0.00%)
Pro 303.34 KB 303.34 KB 0 B (0.00%)

@pirate-bot
Copy link
Contributor

Plugin build for e1d6b21 is ready 🛎️!

@pirate-bot
Copy link
Contributor

E2E Summary

Typing

Test Average Time (ms) Standard Deviation (ms) Median Time (ms) Quantile for soft limit (%) Quantile for hard limit (%)
Typing 82.12 6.63 81.06 0 (60ms) 42.11 (80ms)
Values above 60ms "0 - 89.31, 1 - 87.55, 2 - 73.22, 3 - 71.36, 4 - 79.62, 5 - 77.42, 6 - 80.65, 7 - 85.61, 8 - 102.72, 9 - 79.73, 10 - 84.87, 11 - 75.90, 12 - 84.69, 13 - 84.23, 14 - 82.76, 15 - 81.06, 16 - 82.39, 17 - 79.43, 18 - 77.76"

@rodica-andronache
Copy link

@Soare-Robert-Daniel everything's working well 👍

@HardeepAsrani HardeepAsrani merged commit 6949658 into development Sep 12, 2023
29 checks passed
@HardeepAsrani HardeepAsrani deleted the fix/otter-options-loading branch September 12, 2023 11:01
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 2.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added released Indicate that an issue has been resolved and released in a particular version of the product. pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) labels Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants