Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra nodes when sorting the images in Slider with drag-and-drop. #1833

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

Soare-Robert-Daniel
Copy link
Contributor

Closes #1820

Summary

🔴 I could not find how to fix this by tweaking the props of the HOC component.

🔧 The working solution was a manual cleaning of the extra nodes. It is a little hack, but it works.

Screenshots

2023-08-28.15-41-47.mp4

Test instructions

  1. Create a Slider Block
  2. Add images.
  3. Sort the images using the Drag and Drop feature like in the video above.

Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Aug 28, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review August 28, 2023 13:02
@Soare-Robert-Daniel Soare-Robert-Daniel linked an issue Aug 28, 2023 that may be closed by this pull request
@pirate-bot
Copy link
Contributor

Bundle Size Diff

Package Old Size New Size Diff
Animations 270.78 KB 270.78 KB 0 B (0.00%)
Blocks 1.42 MB 1.42 MB 212 B (0.01%)
CSS 85.28 KB 85.28 KB 0 B (0.00%)
Dashboard 122.49 KB 122.49 KB 0 B (0.00%)
Export Import 83.17 KB 83.17 KB 0 B (0.00%)
Pro 303.27 KB 303.29 KB 12 B (0.00%)

@pirate-bot
Copy link
Contributor

Plugin build for bdb4477 is ready 🛎️!

@pirate-bot
Copy link
Contributor

E2E Summary

Typing

Test Average Time (ms) Standard Deviation (ms) Median Time (ms) Quantile for soft limit (%) Quantile for hard limit (%)
Typing 68.16 3.94 68.17 0 (60ms) 100 (80ms)
Values above 60ms "0 - 64.88, 1 - 61.15, 2 - 60.42, 3 - 62.20, 4 - 69.71, 5 - 67.64, 6 - 68.15, 7 - 68.16, 8 - 73.89, 9 - 71.63, 10 - 68.54, 11 - 69.99, 12 - 68.17, 13 - 67.10, 14 - 68.39, 15 - 68.62, 16 - 76.45, 17 - 72.41, 18 - 67.49"

@irinelenache
Copy link
Contributor

@Soare-Robert-Daniel Tested and the issue is fixed now 👍

@HardeepAsrani HardeepAsrani merged commit de110da into development Aug 31, 2023
@HardeepAsrani HardeepAsrani deleted the fix/slider-image-sorting branch August 31, 2023 07:21
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 2.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added released Indicate that an issue has been resolved and released in a particular version of the product. pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) labels Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image arrangement in Slider is create weird artefacts
4 participants