Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements on the Focus, Hover and secondary buttons in the Otter Dashboard #1843

Closed
mghenciu opened this issue Sep 1, 2023 · 1 comment · Fixed by #1844
Closed
Assignees
Labels
bug This label could be used to identify issues that are caused by a defect in the product. released Indicate that an issue has been resolved and released in a particular version of the product.

Comments

@mghenciu
Copy link
Contributor

mghenciu commented Sep 1, 2023

Description

In Otter dashboard the primary accent colors where dynamic, depending on the theme; and this is causing issues - for example a button is #3858e9, while the toggle is using another accent color.

Another issue is on Accordions, when hovering - those have the same background as the main body. This makes it very hard to see, and has a low contrast.

And the last issue is regarding the Navigation Panels, which don't have a hover state. This is not a good practice, both from an accessibility and UI perspective.

Step-by-step reproduction instructions

  1. The secondary buttons, link, toggles -> should use the same accent color
  2. Test the top navigation, that it has hover state now
  3. Test the Accordion hover state, which should also have more contrast now

Screenshots, screen recording, code snippet or Help Scout ticket

Screenshot 2023-09-01 at 15 21 04
Screen.Recording.2023-09-01.at.13.29.46.mov

No response

Environment info

No response

Is the issue you are reporting a regression

No

@mghenciu mghenciu added the bug This label could be used to identify issues that are caused by a defect in the product. label Sep 1, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel linked a pull request Sep 1, 2023 that will close this issue
9 tasks
@pirate-bot
Copy link
Contributor

🎉 This issue has been resolved in version 2.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This label could be used to identify issues that are caused by a defect in the product. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants