Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strings Review #4339

Open
wants to merge 3 commits into
base: development
Choose a base branch
from
Open

Strings Review #4339

wants to merge 3 commits into from

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Nov 29, 2024 •
edited
Loading

Summary

Add translation function to user-facing strings.

Will affect visual aspect of the product

NO

Screenshots

Test instructions

  • Check if everything is alright. No weird error or text display issue.

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/neve-pro-addon/issues/2880

@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Nov 29, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Nov 29, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review December 3, 2024 15:32
@pirate-bot
Copy link
Collaborator

pirate-bot commented Dec 3, 2024 •
edited
Loading

Plugin build for e0b5816 is ready 🛎️!

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Dec 3, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel requested review from abaicus and removed request for abaicus December 3, 2024 15:36
@Soare-Robert-Daniel Soare-Robert-Daniel force-pushed the fix/translations branch 2 times, most recently from e4c42b5 to cf894cd Compare December 4, 2024 13:47
@Soare-Robert-Daniel Soare-Robert-Daniel changed the title fix: add missing translatable strings Strings Review Dec 10, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel mentioned this pull request Dec 10, 2024
Open
@Soare-Robert-Daniel Soare-Robert-Daniel linked an issue Dec 10, 2024 that may be closed by this pull request
Small alignment issue on the Free vs Pro tab in the Neve Options page #4340
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abaicus abaicus abaicus approved these changes

Assignees

@Soare-Robert-Daniel Soare-Robert-Daniel

Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Small alignment issue on the Free vs Pro tab in the Neve Options page
3 participants
@Soare-Robert-Daniel @pirate-bot @abaicus