Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: [i18n] Added text domain to strings #4097

Merged
merged 5 commits into from
Sep 15, 2023

Conversation

cristian-ungureanu
Copy link
Contributor

@cristian-ungureanu cristian-ungureanu commented Sep 14, 2023

Summary

Added text domain to strings in PaletteForm.js
Fix to admin.php file for displaying color palette and SS notice text translations

Will affect visual aspect of the product

YES/NO

Screenshots

Test instructions

  1. Install Poedit and generate a language file, you can use this video: https://www.youtube.com/watch?v=HzcZeNZu7To&ab_channel=AuroobaMakes.
  2. Translate "Try one of our ready to use Starter Sites" which is the button text of our welcome notice
  3. In WordPress, switch to your new language in dashboard settings
  4. Check the notice button text

Check before Pull Request is ready:

Closes #4096

@pirate-bot pirate-bot added the pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) label Sep 14, 2023
@cristian-ungureanu cristian-ungureanu added pr-checklist-skip Allow this Pull Request to skip checklist. and removed pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) labels Sep 14, 2023
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Sep 14, 2023
@cristian-ungureanu cristian-ungureanu linked an issue Sep 14, 2023 that may be closed by this pull request
@pirate-bot
Copy link
Collaborator

pirate-bot commented Sep 14, 2023

Plugin build for 585dc5d is ready 🛎️!

@irinelenache
Copy link
Contributor

@cristian-ungureanu Tested and everything's fine on my end 🚀

@cristian-ungureanu cristian-ungureanu merged commit e5f7194 into development Sep 15, 2023
15 checks passed
@cristian-ungureanu cristian-ungureanu deleted the fix/i18n-issues branch September 15, 2023 14:54
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 3.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing strings from translation files
4 participants