Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added file on index_select #5673

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

Neema-Joju
Copy link
Contributor

Description

Added a new entry file on .index_select(). Improving documentation and providing more context for the users to understand.

Issue Solved

Closes #5629

Type of Change

  • Adding a new entry
  • Updating the documentation

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@SaviDahegaonkar SaviDahegaonkar self-assigned this Nov 24, 2024
@SaviDahegaonkar SaviDahegaonkar added new entry New entry or entries status: under review Issue or PR is currently being reviewed pytorch PyTorch labels Nov 26, 2024
Copy link
Collaborator

@SaviDahegaonkar SaviDahegaonkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Neema-Joju ,
The entry is nicely written. I have suggested a few changes for this entry. Please make them as soon as possible.

Thanks,
Savi

Comment on lines 55 to 58
tensor([[1, 2, 3, -8],
[-1, 7, 6, 3]])
tensor([[1, 4, -1, 5],
[3, 8, 6, 9]])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tensor([[1, 2, 3, -8],
[-1, 7, 6, 3]])
tensor([[1, 4, -1, 5],
[3, 8, 6, 9]])
tensor([[1, 2, 3, -8],
[-1, 7, 6, 3]])
tensor([[1, 4, -1, 5],
[3, 8, 6, 9]])

This output incorrectly selects values from rows instead of columns, which is incorrect, so please correct the way of printing this output.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first tensor r does select values from the rows not columns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Term Entry] PyTorch Tensor Operations .index_select()
2 participants