Feature: make issues and github stuff work outside of CYF #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MCB need some liberty next I need to either solve pagination or hassle Daniel to make them a proxy...
and yes it works as expected
point to MCB NOTE: the site will not build until all these repos exist, see Migracode-Barcelona/Table-of-Contents#1
is it can be?
they don't know where their SVG is so I just faked it up on photopea
❌ Deploy Preview for cyf-curriculum failed. Why did it fail? →
|
❌ Deploy Preview for cyf-programming failed. Why did it fail? →
|
✅ Deploy Preview for cyf-guides canceled.
|
❌ Deploy Preview for cyf-sdc failed. Why did it fail? →
|
SallyMcGrath
commented
Jul 4, 2024
SallyMcGrath
commented
Jul 4, 2024
SallyMcGrath
commented
Jul 4, 2024
| [params] | ||
| # Don't use the paginating proxy, because it's slow. | ||
| # This means some issues will be missing when fetched. | ||
| issuesorgapi = "https://api.github.com/repos/Migracode-Barcelona/" |
There was a problem hiding this comment.
we can probably rm all this, though I did like just skipping pagination on local
SallyMcGrath
commented
Jul 4, 2024
|
I gott a test this a lot more, but of course am getting rate limited. Another strong argument for no crawling on dev! |
illicitonion
reviewed
Jul 4, 2024
getJSON is deprecated and GetRemote will soon have a way of getting more headers information, allowing us to replace the functionality of Daniel's proxy
no, no idea, I just obey at this point
5 tasks
…ure/mcb-point-to-new-org
why did I leave that in there??
I guess we need to pass the whole api so it works for MCB
we do want it to fail but not THIS much
SallyMcGrath
added a commit
that referenced
this pull request
Jul 17, 2024
…)" This reverts commit 4e1ae71.
SallyMcGrath
added a commit
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
We had limited this to CYF's org because it felt like dangerous madness not to. But actually MCB need their own repos so I've removed the limit.
This reminded me of the problem with paginated issues when trainees start PRing to coursework repos -- the coursework gets pushed off page 1.
So I think I've paginated now? I need to test a bit more, hence draft PR
Common Theme?
This changes the way issues are pulled from github for everyone, which is why this PR is draft until I've tested a bit more.
it affects mainly
issues.html
fetch-paginated-issues.html <= new partial called recursively
The other changes are config changes to remove the old settings.
Note: this won't build! that's because MCB need to create all these repos or remove the links to them.
That's happening on this ticket Migracode-Barcelona/Table-of-Contents#1
On my local copy of MCB, I have just deleted all content except JS1, as I have created that test module to build this stuff.
Org Content?
I also made a logo just because it was bugging me a lot to look at
Checklist
Who needs to know about this?