London | Zohreh-Kazemianpour | Structuring-and-testing-data | week3 | sprint 3 #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zohrehKazemianpour
added
the
Needs Review
zohrehKazemianpour
changed the title
cjyuan
reviewed
Dec 11, 2024
There was a problem hiding this comment.
You probably have created your Sprint-3 branch from your Sprint-2 branch (instead of from "main"). Now the current branch includes also modified files in Sprint-2 folder.
Can you rebase your Sprint-3 branch onto "main"? If you need help doing so, you can ask a volunteer on Saturday or DM me on Slack.
|
@zohrehKazemianpour can you please make sure you address what reviewers ask you to do and change the label ? |
ellietms
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.