Millena mesfin/Sprint-3-exercises/structuring and testing data #222
Conversation
| @@ -4,6 +4,45 @@ | |||
|
|
|||
| // You need to write assertions for your function to check it works in different cases | |||
|
|
|||
| function getCardValue(card) { | |||
| // Check if the card is a number between 2 and 9 | |||
| if (Number(card[0]) >= 2 && Number(card[0]) <= 9) { | |||
There was a problem hiding this comment.
Since rank can be any invalid value, you cannot just check the first character.
Examples of cards with invalid rank include "23♠", "777♠", "10K♠", "AA♠"
|
|
||
| console.log(isProperFraction(2, 3)); | ||
| console.log(isProperFraction(5, 2)); | ||
| console.log(isProperFraction(-4, 7)); |
There was a problem hiding this comment.
In mathematics, -4/7 == 4/-7, and -4/-7 == 4/7.
So, ideally isProperFraction() should recognise all of them as proper fractions.
Hint: If you compute the absolute value of both parameters inside the function first, the code can become much simpler.
| if (a <= 0 || b <= 0 || c <= 0) { | ||
| return false; | ||
| } | ||
| if (a + b > c && a + c > b && b + c > a) { |
There was a problem hiding this comment.
If any of a, b, c are negatives, then they will also not pass the triangle inequality check. (You can verify yourself)
So why also include the if statements in lines 39-41?
| @@ -41,3 +41,34 @@ console.log(rotateCharacter("7", 5)); // Output: "7" (unchanged, not a letter) | |||
| // And the function should return the rotated character as a string (e.g., 'z' rotated by 3 should become 'c', 'Z' rotated by 3 should become 'C'). | |||
| console.log(rotateCharacter("z", 1)); // Output: "a" (preserves case, but wraps around) | |||
| console.log(rotateCharacter("Y", 2)); // Output: "A" (preserves case, but wraps around) | |||
|
|
|||
| function rotateCharacter(char, n) { | |||
| if (!/^[a-zA-Z]$/.test(char)) return "Unchanged, not a letter"; | |||
There was a problem hiding this comment.
The spec means, if char is not a letter, return char.
| newCharCode = newCharCode - 26; | ||
| return `Output: ${String.fromCharCode( | ||
| newCharCode | ||
| )} (preserves case, but wraps around)`; |
| @@ -33,3 +33,41 @@ These are the requirements your project needs to fulfill: | |||
| - Return a boolean from the function to indicate whether the credit card number is valid. | |||
|
|
|||
| Good luck! | |||
|
|
|||
|
|
|||
| function validateCreditCard(cardNumber) { | |||
There was a problem hiding this comment.
Can you implement this in card-validator.js and prepare the test script in card-validator.test.js?
| test("handles special characters", () => { | ||
| expect(countChar("!@#$$%^^&", "$")).toBe(2); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Where is the function this test script is testing?
| expect(isPrime(100)).toBe(false); | ||
| expect(isPrime(150)).toBe(false); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
I think you were also supposed to implement the function isPrime(num) (and not just prepare the tests).
| test("should return true if password length is at least 5 characters", () => { | ||
| expect(isValidPassword("abcde", [])).toBe(true); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Can you also implement the function isValidPassword()?
These tests are not comprehensive. For example, it didn't test if the function can correctly check if a password is missing only an uppercase letter.
cjyuan
added
Reviewed
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.