CYF-ITP-South Africa | Simphiwe Mabuya | Module-Data-Groups | Sprint-3-Quote-Generator #279
+5,372
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…heir CSS id selectors
… values from the quotes Array of objects
…rom both quote and author quotes properties
…playing the quote and it's author
…on file to get my test to pass
… 02 twice, onload and on click thus affecting expected value
3 tasks
KudahShambare
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
In your title make sure you are consistent with your case (some words starting with uppercse some with lowercase).
You can also make use of the defer attribute in your script tag
KudahShambare
added
Reviewed
…ttribute to my script tag
|
Greetings again Kudah
On Sprint-3/quote-generator/index.html:
In your title make sure you are consistent with your case (some words
starting with uppercse some with lowercase).
- I have updated my title to be case consistent as per your advice.
You can also make use of the defer attribute in your script tag
- I also included the defer attribute to my script tag per your suggestion.
Thanks a million yet again Mr Kudah for your feedback.
Best regards
Simphiwe Mabuya
…On Thu, 9 Jan 2025 at 10:37, Kudakwashe Shambare ***@***.***> wrote:
@KudahShambare approved this pull request.
Great work!! You can proceed with the stretch goals.
________________________________
On Sprint-3/quote-generator/index.html:
In your title make sure you are consistent with your case (some words starting with uppercse some with lowercase).
You can also make use of the defer attribute in your script tag
https://www.w3schools.com/tags/att_script_defer.asp
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.