Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

West Midlands | Gabriel Deng | Module-Data-Groups | Week 3 - Slide show #277

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

West Midlands | Gabriel Deng | Module-Data-Groups | Week 3 - Slide show #277

wants to merge 1 commit into from
+103 −6

Conversation

gai93003
Copy link

@gai93003 gai93003 commented Jan 7, 2025

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@gai93003 gai93003 added the Needs Review Participant to add when requesting review label Jan 7, 2025
@illicitonion illicitonion removed the Needs Review Participant to add when requesting review label Jan 7, 2025
@illicitonion
Copy link
Member

This has the same problem as #220 :) Please use git rebase -i to get rid of the unrelated commits, then re-add the Needs Review label.

@gai93003
Copy link
Author

gai93003 commented Jan 9, 2025

I think it is now finally rebased.

@gai93003 gai93003 added the Needs Review Participant to add when requesting review label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review Participant to add when requesting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gai93003 @illicitonion