Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CYF-ITP-South Africa | Emmanuel Siziba | Module-Data-Groups | sprint-3 Quote Genarator app #264

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

CYF-ITP-South Africa | Emmanuel Siziba | Module-Data-Groups | sprint-3 Quote Genarator app #264

wants to merge 17 commits into from

Conversation

EmmanuelSiziba
Copy link

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@EmmanuelSiziba EmmanuelSiziba added the Needs Review Participant to add when requesting review label Dec 30, 2024
@EmmanuelSiziba
Copy link
Author

image

KudahShambare
KudahShambare approved these changes Jan 7, 2025
View reviewed changes
Copy link

@KudahShambare KudahShambare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!!!! The text to voice feature is amazing.

Sprint-3/quote-generator/quotes.js
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For your copy to clipboard and share via twitter, it will be great if you also include the aurthor of the quote

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, Thank you for the feedback kuda, i will do that

@KudahShambare KudahShambare added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Jan 7, 2025
@EmmanuelSiziba EmmanuelSiziba added Complete Participant to add when work is complete and review comments have been addressed and removed Reviewed Volunteer to add when completing a review labels Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KudahShambare KudahShambare KudahShambare approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Complete Participant to add when work is complete and review comments have been addressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EmmanuelSiziba @KudahShambare