Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

London | Emmanuel Gessessew| Module-Data-Groups | WEEK 2 #261

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Emmanuelgessessew
Copy link

Learners, PR Template

Self checklist

  • [yes ] I have committed my files one by one, on purpose, and for a reason
  • [ yes] I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • [ yes] I have tested my changes
  • [ yes] My changes follow the style guide
  • [ yes] My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@Emmanuelgessessew Emmanuelgessessew added the Needs Review Participant to add when requesting review label Dec 30, 2024
expect(contains(obj, "c")).toBe(false);
});

test("returns false for invalid inputs like an array", () => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see adding many types of unit tests covering corner scenarios

@vamsikrishna-oc vamsikrishna-oc added Reviewed Volunteer to add when completing a review Complete Participant to add when work is complete and review comments have been addressed and removed Needs Review Participant to add when requesting review labels Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complete Participant to add when work is complete and review comments have been addressed Reviewed Volunteer to add when completing a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants