Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NW6 | Pedram Amani | HTML-CSS | Module Project | Week 1,2,4 #640

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

pedram-am
Copy link

@pedram-am pedram-am commented Sep 28, 2023

Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in HOW_TO_MARK.md in the root of this repository

Your Details

  • Your Name: Pedram Amani
  • Your City: Manchester
  • Your Slack Name: pedram-am

Homework Details

  • Module: HTML-CSS
  • Week: 1, 2, and 4

Notes

  • What did you find easy?
    The text content part.

  • What did you find hard?
    Adjusting layouts, design requirements and troubleshooting issues.

  • What do you still not understand?
    Keeping images, texts and layouts clear and maintaining their quality when the screen size changes.

  • Any other notes?

  • No.

@netlify
Copy link

netlify bot commented Sep 28, 2023

Deploy Preview for cyf-module-project-html-css ready!

Name Link
🔨 Latest commit 817b755
🔍 Latest deploy log https://app.netlify.com/sites/cyf-module-project-html-css/deploys/653eeb30c1ae6e0007ff1f50
😎 Deploy Preview https://deploy-preview-640--cyf-module-project-html-css.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@bunday bunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done,

See my comment about the margin on the whole body. Also can you try to reduce the overall font a bit?

* for example: General styles, Navigation styles, Hero styles, Footer etc.
*
* - When using Flexbox, remember the items you want to move around need to be inside a parent container set to 'display: flex'
*/

body {
margin: 40px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a margin on the entire body affects the image from filling the sides of the screen, can you remove this margin and apply it to appropriate elements

@pedram-am pedram-am changed the title NW6 | Pedram Amani | HTML-CSS | Module Project | Week 1 NW6 | Pedram Amani | HTML-CSS | Module Project | Week 1,2,4 Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants