-
-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NW6 | Pedram Amani | HTML-CSS | Module Project | Week 1,2,4 #640
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for cyf-module-project-html-css ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done,
See my comment about the margin on the whole body. Also can you try to reduce the overall font a bit?
* for example: General styles, Navigation styles, Hero styles, Footer etc. | ||
* | ||
* - When using Flexbox, remember the items you want to move around need to be inside a parent container set to 'display: flex' | ||
*/ | ||
|
||
body { | ||
margin: 40px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a margin on the entire body affects the image from filling the sides of the screen, can you remove this margin and apply it to appropriate elements
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.md
in the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
The text content part.
What did you find hard?
Adjusting layouts, design requirements and troubleshooting issues.
What do you still not understand?
Keeping images, texts and layouts clear and maintaining their quality when the screen size changes.
Any other notes?
No.