-
-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NW6 | Nohe_Tekelmariyam | HTML-CSS | Module_project | Week2 #637
base: master
Are you sure you want to change the base?
NW6 | Nohe_Tekelmariyam | HTML-CSS | Module_project | Week2 #637
Conversation
✅ Deploy Preview for cyf-module-project-html-css ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added HTML and CSS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
first module project after added css
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, good attempt so far, I left a couple of comments which I noticed are repetitive in your design, you should fix for all scenarios. Take a look at the image attached here for a clear example of what you are trying to replicate. Feel free to reach out on slack if you need any more clarification.
For the store page, it doesnt look like the required page quite yet, can you take a look again and have some updates on it again
Can you also fill in your details on the PR? thanks
index.html
Outdated
|
||
<li class="nav-item"> | ||
<a class="nav-link" href="#">Meet Karma</a> </li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be in black, while the other links should be in grey
</div> | ||
</div> | ||
|
||
<article class="article"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section also have issue with justify-content: center
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.md
in the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?