Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NW6 | Nohe_Tekelmariyam | HTML-CSS | Module_project | Week2 #637

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

nohetekelmariyam
Copy link

Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in HOW_TO_MARK.md in the root of this repository

Your Details

  • Your Name:
  • Your City:
  • Your Slack Name:

Homework Details

  • Module:
  • Week:

Notes

  • What did you find easy?

  • What did you find hard?

  • What do you still not understand?

  • Any other notes?

@netlify
Copy link

netlify bot commented Sep 26, 2023

Deploy Preview for cyf-module-project-html-css ready!

Name Link
🔨 Latest commit c68cf5d
🔍 Latest deploy log https://app.netlify.com/sites/cyf-module-project-html-css/deploys/6533b5604dedaa0008023a15
😎 Deploy Preview https://deploy-preview-637--cyf-module-project-html-css.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Author

@nohetekelmariyam nohetekelmariyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added HTML and CSS

Copy link
Author

@nohetekelmariyam nohetekelmariyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first module project after added css

@nohetekelmariyam nohetekelmariyam changed the title module project NW6 | Nohe_Tekelmariyam | HTML-CSS | Module_project | Week1 Sep 27, 2023
@nohetekelmariyam nohetekelmariyam changed the title NW6 | Nohe_Tekelmariyam | HTML-CSS | Module_project | Week1 NW6 | Nohe_Tekelmariyam | HTML-CSS | Module_project | Week2 Oct 2, 2023
Copy link

@bunday bunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, good attempt so far, I left a couple of comments which I noticed are repetitive in your design, you should fix for all scenarios. Take a look at the image attached here for a clear example of what you are trying to replicate. Feel free to reach out on slack if you need any more clarification.

For the store page, it doesnt look like the required page quite yet, can you take a look again and have some updates on it again

Can you also fill in your details on the PR? thanks

css/style.css Outdated Show resolved Hide resolved
css/style.css Outdated Show resolved Hide resolved
index.html Outdated

<li class="nav-item">
<a class="nav-link" href="#">Meet Karma</a> </li>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in black, while the other links should be in grey

index.html Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
</div>
</div>

<article class="article">
Copy link

@bunday bunday Oct 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section also have issue with justify-content: center

@nohetekelmariyam nohetekelmariyam requested review from bunday and removed request for bunday October 16, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants