Week3 selina hussain #83
Conversation
…umbotron image. Used bootstrap to create navbar with toggle menu for mobile only. Css styling used to change background colour of navbar.
…d class to hide p text on mobile view. Added hover styling to nav links. Added styling to jumbotron.
…. added styling to card section with bg and button colours.
…ier to see and read. Compressed image files so it will take less time for the page to load.
| crossorigin="anonymous" | ||
| /> | ||
| <link | ||
| href="//maxcdn.bootstrapcdn.com/font-awesome/4.2.0/css/font-awesome.min.css" |
There was a problem hiding this comment.
This link doesn't look correct, and it's not outputting Font Awesome into your file.
| <!-- Jumbotron Section --> | ||
| <section class="container" id="about"> | ||
| <div class="jumbotron text-center"> |
There was a problem hiding this comment.
Here, the container could have probably gone inside the jumbotron to give it a bit more width.
For example: https://www.w3schools.com/bootstrap4/tryit.asp?filename=trybs_jumbotron2&stacked=h
| </div> | ||
| </div> | ||
| <div class="col-sm-12 col-md-6 col-lg-3"> |
There was a problem hiding this comment.
These cards may have benefitted from a bit of margin between each other at mobile widths.
| <div class="col"> | ||
| <h2 | ||
| class="display-12 font-weight-bold mt-5 pt-3 mb-5 pb-3 text-center" |
There was a problem hiding this comment.
You can use my and py if the passing or margin is the same for top & bottom. That means you don't have to write out the classes twice.
| </div> | ||
| <div class="form-group row"> | ||
| <label for="inputEmail3" class="col-sm-5 col-form-label" |
There was a problem hiding this comment.
Good work on adding accessible labels for the forms.
| opacity: 0.8; | ||
| } | ||
|
|
||
| .btns { |
There was a problem hiding this comment.
btn-primary or btn-secondary might have been more appropriate classes in this case, as .btns isn't really descriptive to the next developer as to what the intention is.
No description provided.