Improve tags (using filament translations) #129
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package has no translations, it only uses 2 labels
placeholder
andgetEmptyLabel
that can be configured. If not configured, they use a default English label from the javascript library.This PR configures by default the filament labels that already have translations.
In the case of
placeholder
, bothSelect
andSelectTree
implement theHasPlaceholder
trait. In theSelect
component, a translatable label is set onsetup
function.https://github.com/filamentphp/forms/blob/3.x/src/Components/Select.php#L195
The same criteria is taken for
SelectTree
.On the other hand,
getEmptyLabel
, theSelect
component andSelectTree
implement aCanBeSearchable
trait, which already has a noSearchResultsMessage property, where it has a translatable label.https://github.com/filamentphp/forms/blob/3.x/src/Components/Concerns/CanBeSearchable.php#L75
The
getEmptyLabel
andemptyLabel
functions now calls the trait's methods for compatibility.