Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix style dark in button clear #126

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

gpibarra
Copy link
Contributor

chrome-capture-2024-10-27

@CodeWithDennis
Copy link
Owner

Hi @gpibarra, thanks for your effort! However, the color of the close button is the same as the default select field in Filament. If you'd like to change it, you can do that in your theme's CSS file.

@gpibarra
Copy link
Contributor Author

gpibarra commented Oct 27, 2024

Hi @CodeWithDennis , the button is NOT the same in terms of css, if I change the template this does not change.

On the contrary, the styles of this button (and its svg content) are replicated and match the original button.

The code I just put is exactly the same as the code that is in the original repository https://github.com/filamentphp/forms/blob/68c9f7f4bd9677f6f99d21396dfbe69cfa142584/resources/css/components/select.css#L117

@CodeWithDennis
Copy link
Owner

Could you show a standard select field and a select tree next to each other? They seem identical to me on my side.

@gpibarra
Copy link
Contributor Author

Sorry for my English, maybe I didn't explain myself well.
When I say THEY ARE NOT THE SAME, I mean that they are not linked, that is, if the original Filament theme is changed, it will not impact the style of the button in this library.
So, the icons are copied and ARE EQUALS, although the style for the dark theme was not copied, which is what I would be adding in this PR.

@CodeWithDennis
Copy link
Owner

Got it. So you’re saying that a normal select and a tree select in your project look the same due to their shared styles. Could you provide an example with a side by side view.

@gpibarra
Copy link
Contributor Author

When installing the select-tree library, in light mode, the button looks the same, since the styles of .treeselect-input__clear in https://github.com/CodeWithDennis/filament-select-tree/blob/3. x/resources/css/index.css are the same as those of normal select with the class .choices__button in https://github.com/filamentphp/forms/blob/3. x/resources/css/components/ select.css.

But in dark mode, filament had a specific style for .dark .choices__button while here there was no style for .dark .treeselect-input__clear.

The video shows that the select-tree button, when switched to dark mode, is almost invisible, while normal-select, in dark mode, has a color that allows it to be seen correctly.

@CodeWithDennis
Copy link
Owner

Sorry for the misunderstanding; it looks like a good fix. Thanks!

@CodeWithDennis CodeWithDennis merged commit 0450c9d into CodeWithDennis:3.x Oct 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants