-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix style dark in button clear #126
Conversation
gpibarra
commented
Oct 27, 2024
Hi @gpibarra, thanks for your effort! However, the color of the close button is the same as the default select field in Filament. If you'd like to change it, you can do that in your theme's CSS file. |
Hi @CodeWithDennis , the button is NOT the same in terms of css, if I change the template this does not change. On the contrary, the styles of this button (and its svg content) are replicated and match the original button. The code I just put is exactly the same as the code that is in the original repository https://github.com/filamentphp/forms/blob/68c9f7f4bd9677f6f99d21396dfbe69cfa142584/resources/css/components/select.css#L117 |
Could you show a standard select field and a select tree next to each other? They seem identical to me on my side. |
Sorry for my English, maybe I didn't explain myself well. |
Got it. So you’re saying that a normal select and a tree select in your project look the same due to their shared styles. Could you provide an example with a side by side view. |
When installing the select-tree library, in light mode, the button looks the same, since the styles of But in dark mode, filament had a specific style for The video shows that the select-tree button, when switched to dark mode, is almost invisible, while normal-select, in dark mode, has a color that allows it to be seen correctly. |
Sorry for the misunderstanding; it looks like a good fix. Thanks! |