d l mcbride solutions for day 2 to day 6 #380
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aaditkamat or @MadhavBahl, sorry to bother you guys, but was trying to make the Hacktoberfest deadline for a couple of pull request. Could you add the "hacktoberfest-accepted" label to this. Thank you for your help! :) |
aaditkamat
reviewed
Nov 1, 2020
|
|
||
| fun hammingDistance(first: String, second: String ):Int { | ||
| var distance = 0 | ||
| for(i in first.indices) { |
There was a problem hiding this comment.
Need to verify that the two strings are of the same length before checking for the hamming distance between the two strings.
aaditkamat
reviewed
Nov 1, 2020
|
|
||
| val THREE_MID = "helllo" | ||
| val ONE_EACH = "abcd" | ||
| val FOUR_END = "byeeee" |
There was a problem hiding this comment.
You should ideally have test cases where the character appearing most frequently does not appear in consecutive positions.
aaditkamat
reviewed
Nov 1, 2020
| println() | ||
| } | ||
| } | ||
| fun patterThree(longestLine: Int){ |
There was a problem hiding this comment.
Suggested change
| fun patterThree(longestLine: Int){ | |
| fun patternThree(longestLine: Int){ |
aaditkamat
reviewed
Nov 1, 2020
| } | ||
| patternOne(5) | ||
| patternTwo(lines = 4) | ||
| patterThree(5) |
There was a problem hiding this comment.
Suggested change
| patterThree(5) | |
| patternThree(5) |
aaditkamat
reviewed
Nov 1, 2020
| } | ||
| fun patterThree(longestLine: Int){ | ||
| (1..(longestLine*2-1)).forEach {line -> | ||
| if(line<=5) (1..line).forEach { pos ->print("${pos} ") } else (1..(2*longestLine-line)).forEach {less ->print("${less} ") } |
There was a problem hiding this comment.
Suggested change
| if(line<=5) (1..line).forEach { pos ->print("${pos} ") } else (1..(2*longestLine-line)).forEach {less ->print("${less} ") } | |
| if(line<=longestLine) (1..line).forEach { pos ->print("${pos} ") } else (1..(2*longestLine-line)).forEach {less ->print("${less} ") } |
aaditkamat
suggested changes
Nov 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure you have done the following:
/Day<n>/<Language>//Day <n>/all-contributors-cli