Hotfix for critical bug 1043 #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
The normal PR process for this team is to submit a PR against However, I submitted this hotfix PR against main and skipped staging. That's because staging currently has code that haven't been deployed to main yet. I didn't want to "muddy the water" and submit a PR from staging with unrelated code. I wanted to keep a separation of concerns: hotfix should go in its own PR and not be mixed up with unrelated code. Moreover, I wanted to avoid the possibility of introducing any potential bug in staging to main/production. |
This was referenced Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request is a hotfix for #1043, a critical bug that crashes the website after a user searches a property.
This PR fixes the bug by reverting PR #1003, and part of another, #1008
Screen recording
hotfix.pr.1050.mov