-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/rb 26 cart #35
base: dev
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for rebooksctd ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice job in this PR! Other than some small things, I noticed that adding to the cart doesn't always work for me properly: I can't add some books, and after adding some books I'm not being redirected to the /cart
page. Also, I'm getting some console errors when trying to delete items from the cart.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like how you split Cart into multiple components but after a closer look I saw some more improvements. After you fix those, I believe this PR should be good to go.
Description
add cartPage and cart functionality, delete book from cart, add book to cart from book page
Changes
Related issues
Screenshots
add book to cart
book added to cart
if the user not logged in the cart is not visible
if the cart is empty