-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HER-45 Speaker Index Page #47
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhope21
requested review from
raquii,
bbcc33,
trca831,
dewi-anggraini,
olesiamironenko and
dsinn
as code owners
January 8, 2025 00:09
trca831
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sorry about all these commits. Most of them are from doing rebase every time main changed. |
raquii
changed the base branch from
main
to
HER-14-Create-name-method-for-User
January 9, 2025 02:45
raquii
changed the base branch from
HER-14-Create-name-method-for-User
to
main
January 9, 2025 02:45
raquii
force-pushed
the
HER-45-Speaker-Index-Page
branch
from
January 10, 2025 15:53
25e1ba2
to
946c0aa
Compare
mhope21
force-pushed
the
HER-45-Speaker-Index-Page
branch
from
January 10, 2025 17:43
946c0aa
to
6a2157c
Compare
trca831
approved these changes
Jan 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
olesiamironenko
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HER-45: Create Speaker Index Page [FE]
Issue
https://raquelanaroman.atlassian.net/browse/HER-45
Description
As a teacher user, I want to browse all speakers to find someone suitable for my event.
Deliverables:
Display speaker cards with name, bio, image, and a link to profile.
Basic layout and styling for speaker cards.
Mock data for testing.
Acceptance Criteria
The Speakers page displays each speaker user with the following information: name, bio, image, and a “View Profile” button.
Clicking “View Profile” navigates to speaker user’s profile page.
https://raquelanaroman.atlassian.net/browse/HER-46
https://raquelanaroman.atlassian.net/browse/HER-47
Changes
Review Checklist