Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HER-46-Add-Bio-Field-to-User-Model #34

Merged
merged 13 commits into from
Jan 5, 2025
Merged

Conversation

bbcc33
Copy link
Collaborator

@bbcc33 bbcc33 commented Dec 30, 2024

HER-46-Add-Bio-Field-to-User-Model

Issue

https://raquelanaroman.atlassian.net/browse/<JIRA_TICKET_ID>

Description

As a User, I want the option to add my bio to personalize my profile and include my credentials or qualifications.
Acceptance Criteria

Add “bio” column to “users” table: type: text, default: null, optional(not required).

Update strong parameters to permit “bio”.

Update the UserProfileSerializer to include “bio” in the response.

Implementation:

Generate a migration to add the “bio” column: 

rails generate migration AddBioToUsers bio:text
rails db:migrate

Permit “bio” in strong parameters.

Add “bio” to the UserProfileSerializer.

Include in existing tests or write tests to validate functionality.

HER-30, HER-45. HER-48. HER-49

Changes

added bio parameter to user_params in users_controller.rb
added bio parameter to user_profile_serializer.rb
added bio column to users table
added a check for a bio entry in spec/requests/users_spec.rb

Review Checklist

  • I have documented my code with code comments.

Copy link
Collaborator

@mhope21 mhope21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of your checks failed for migration. Did you run it before pushing?

db/migrate/20241229054450_add_bio_to_users.rb Show resolved Hide resolved
@bbcc33 bbcc33 merged commit 74ec7fa into main Jan 5, 2025
3 checks passed
@bbcc33 bbcc33 deleted the HER-46-Add-Bio-Field-to-User-Model branch January 5, 2025 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants