Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HER-31: fix devise JWT #20

Merged
merged 2 commits into from
Dec 6, 2024
Merged

HER-31: fix devise JWT #20

merged 2 commits into from
Dec 6, 2024

Conversation

raquii
Copy link
Collaborator

@raquii raquii commented Dec 6, 2024 •
edited
Loading

Issue

https://raquelanaroman.atlassian.net/browse/HER-31

This was to fix issues with local development and the testing suite.

Changes

  • remove unnecessary credentials files
  • use a default value for devise JWT in development instead of SecureRandom
  • add back cookies and sessions to application config

Review Checklist

  • I have documented my code with code comments.

@raquii raquii force-pushed the HER-31-fix-ci-test-suite branch from 44041da to 56f14db Compare December 6, 2024 17:34
@raquii raquii force-pushed the HER-31-fix-ci-test-suite branch from 56f14db to c3b408a Compare December 6, 2024 17:37
@raquii raquii changed the title fix devise JWT HER-31: fix devise JWT Dec 6, 2024
@raquii raquii marked this pull request as ready for review December 6, 2024 17:40
@raquii raquii merged commit 4acc7a2 into main Dec 6, 2024
3 checks passed
@raquii raquii deleted the HER-31-fix-ci-test-suite branch December 6, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhope21 mhope21 mhope21 approved these changes

@bbcc33 bbcc33 Awaiting requested review from bbcc33 bbcc33 is a code owner

@trca831 trca831 Awaiting requested review from trca831 trca831 is a code owner

@dewi-anggraini dewi-anggraini Awaiting requested review from dewi-anggraini dewi-anggraini is a code owner

@olesiamironenko olesiamironenko Awaiting requested review from olesiamironenko olesiamironenko is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raquii @mhope21