-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HER 16: Migration -- remove name column from users table #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your migration is great! I want you to run this on your branch, though
git checkout HER-16-Migration-drop-name-column-from-Users
git fetch
git rebase origin/main
# resolve any conflicts, overwrite the credentials files entirely if you need to
# please DM me on slack if you want help resolving conflicts!
git push --force
app/models/user.rb
Outdated
@@ -13,7 +13,7 @@ class User < ApplicationRecord | |||
|
|||
before_create :set_default_role | |||
|
|||
validates :name, presence: true | |||
# validates :name, presence: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good, actually. This is a good way to keep this branch scoped to what your changes should be.
However, we obviously will wait to deploy this until the blocking, dependent branches have shipped, so you will end up not needing this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @raquii Before I do this (what you commented above this regarding what to run on my branch), should I do a git pull?
80ba630
to
71b7672
Compare
eadaa2a
to
d2f4022
Compare
[HER-16] Migration: Drop name column from User
Issue
https://raquelanaroman.atlassian.net/browse/HER-16
As a developer, I would like to remove tech debt from my app by removing the name column from users table.
Acceptance Criteria: create a migration that removes the name column from users
Links:
Changes
Review Checklist