HER-23-add-teacher-to-roles-in-user #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhope21
requested review from
raquii,
bbcc33,
dewi-anggraini and
olesiamironenko
as code owners
raquii
previously approved these changes
Nov 26, 2024
Comment on lines
20
to
28
| setIsTeacher((prevIsTeacher) => { | ||
| const newIsTeacher = !prevIsTeacher; | ||
| if (newIsTeacher) { | ||
| console.log("I am a Teacher"); | ||
| } else { | ||
| console.log("I am not a teacher"); | ||
| } | ||
| return newIsTeacher; | ||
| }); |
Co-authored-by: Raquel Román-Rodriguez <[email protected]>
Co-authored-by: Raquel Román-Rodriguez <[email protected]>
|
Merge conflicts resolved. Fixed missing closing div on Registration page. |
raquii
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HER-23: Add
teacherto roles in userIssue
https://raquelanaroman.atlassian.net/browse/HER-23
As a teacher-user, I would like a way to distinguish myself from other types of users in the application.
Acceptance Criteria
HER-24
Changes
User model (app/models/user.rb):
Review Checklist