-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Her 17 migration for renaming kit requests to orders #12
Her 17 migration for renaming kit requests to orders #12
Conversation
Similar to my comments to @mhope21 in #9, you would normally need to fix the failing tests before this PR can be approved. However, this is a subtask ticket and we are renaming the entire model, I am going to ask you to complete the other subtask, https://raquelanaroman.atlassian.net/browse/HER-18, and complete it on this same branch. Otherwise, we will break tests for everyone if we merge this "as is", (which is why merging isn't allowed when tests fail). The migration looks great, though! ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Very thorough. We are encouraged to comment our changes I think, but this is really good. I think there are some conflicts to resolve on your PR. Check it out.
Thanks, Marcia! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good. Just one thing: I think we missed replacing kit_requests
here:
herring-team-3/app/models/user.rb
Line 10 in aefbaaa
has_many :kit_requests |
Since there are those lines in order model: and in user model: should it be this line in kit model? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Issue
https://raquelanaroman.atlassian.net/browse/<JIRA_TICKET_ID>
Create a migration that renames the kit_requests table to orders
Changes
Review Checklist