Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dshell.json #275

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update Dshell.json #275

wants to merge 3 commits into from

Conversation

dek443
Copy link

@dek443 dek443 commented May 13, 2021

Thanks for submitting a pull request! Below are a few things you can do to help us more quickly review your changes.

Checklist

I have…

  • run the application locally (./scripts/serve) and verified that my changes behave as expected.
  • run the build process locally (./scripts/build) and make sure it builds correctly.
  • run the test suite (./scripts/test) and verified that all tests pass.
  • summarized below my changes and noted which issues (if any) this pull request fixes or addresses.
  • thoroughly outlined below the steps necessary to test my changes.
  • attached screenshots illustrating relevant behavior before and after my changes.
  • read, understand, and agree to the terms described in CONTRIBUTING.md.
  • added my name, email address, and copyright date to CONTRIBUTORS.md.

Summary of Changes

This pull request…

  • Summarize change number one.
  • Summarize change number two.
  • etc. etc. etc.

Testing

To verify the changes proposed in this pull request…

  1. Describe testing step one.
  2. Describe testing step two.
  3. etc. etc. etc.

Screenshots

Attach relevant before and after screenshots here.

},
"laborHours": 1,
"laborHours": [],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a number or else left off

@david-saeger
Copy link
Contributor

@dek443 sorry for the delay in reviewing this PR. All looks good except the type for laborHours. If you remove it ill pull this in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants