Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed hardcoded email text to site reference [issue #235] #260

Merged
merged 2 commits into from
Nov 15, 2019

Conversation

Brorean
Copy link
Contributor

@Brorean Brorean commented Nov 15, 2019

In the site footer changed hardcoded email text to a variable site.email. This is for issue #235.

@jordangov
Copy link
Contributor

Thanks @Brorean ! We appreciate the PR. We'll need to have you sign the CONTRIBUTORS.md file before we can accept the PR, and we do have a PR template that seems to have gotten lost here. Can you please pull that in and check of the items as you've completed them?

I know this is a small change, but we're trying to make sure we can have a solid process for all contributions.

@jordangov jordangov changed the title changed hardcoded email text to site reference [issue 235] changed hardcoded email text to site reference [issue #235] Nov 15, 2019
@Brorean
Copy link
Contributor Author

Brorean commented Nov 15, 2019

Checklist

I have…

  • [*] run the application locally (./scripts/serve) and verified that my changes behave as expected.
  • [*] run the build process locally (./scripts/build) and make sure it builds correctly.
  • [*] run the test suite (./scripts/test) and verified that all tests pass.
    ** For some reason the test fails on my virtual machine on ./public/how-to-open-source.html with error External link https://code.gov/about/compliance/inventory-code failed: 404 No error
  • [*] summarized below my changes and noted which issues (if any) this pull request fixes or addresses.
  • [*] thoroughly outlined below the steps necessary to test my changes.
  • [*] attached screenshots illustrating relevant behavior before and after my changes.
  • [*] read, understand, and agree to the terms described in CONTRIBUTING.md.
  • [*] added my name, email address, and copyright date to CONTRIBUTORS.md.

Summary of Changes

Changed the site footer to use site.email instead of hard coded value.

Testing

Start server using ./scripts/serve and open in web browser. Scroll to the footer in the page and verify that the [email protected] email address appears. Click on page and view source. Scroll to the footer and verify that the reference uses {{site.email}}.

Screenshots

Before:
Screenshot from 2019-11-15 10-31-02

After:
Footer html

Footer on main page

@jordangov
Copy link
Contributor

Thank you so much! Really appreciate the effort, and feel free to hack on anything else ;)

@jordangov jordangov merged commit 3ef09b4 into Code-dot-mil:master Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants