Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer Email Reference #235

Open
TangoYankee opened this issue Jul 15, 2018 · 4 comments
Open

Footer Email Reference #235

TangoYankee opened this issue Jul 15, 2018 · 4 comments

Comments

@TangoYankee
Copy link

Feature

Increase maintainability of references in footer

Affected Area

footer, lines 58 & 59

Description

'href' for email uses a liquid reference to the configuration file. However, the associated 'text' is hard-coded. hard-coding could be replaced with:

'{{site.email}}'
@TangoYankee
Copy link
Author

Note this works for ruby version 2.3. It may break for 2.5

@jordangov
Copy link
Contributor

Hey @TangoYankee ! Thanks for the report. I think I recall trying to do this at one point and it not working for some reason. That said, if it works, we should do it! PRs welcome. ;)

@tinjaw
Copy link

tinjaw commented Aug 26, 2020

I believe this is resolved and should be closed? Is that true?

@zacnomore
Copy link

href: mailto:{{site.email}}

Agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants