Add notices for non-release builds

ClientCore/ClientConfiguration.cs

@@ -389,6 +389,11 @@ public IEnumerable<string> SupplementalMapFileExtensions
         /// </summary>
         public bool DisallowJoiningIncompatibleGames => clientDefinitionsIni.GetBooleanValue(SETTINGS, nameof(DisallowJoiningIncompatibleGames), false);
 
+        /// <summary>
+        /// Activates warnings for non-release build of XNA Client
+        /// </summary>
+        public bool ShowDevelopmentBuildWarnings => clientDefinitionsIni.GetBooleanValue(SETTINGS, nameof(ShowDevelopmentBuildWarnings), true);
+
         #endregion
 
         #region Network definitions

DXMainClient/DXGUI/GameClass.cs

@@ -10,7 +10,7 @@
 using Rampastring.Tools;
 using Rampastring.XNAUI;
 using System;
 using ClientGUI;
 using DTAClient.Domain.Multiplayer;
 using DTAClient.Domain.Multiplayer.CnCNet;
 using DTAClient.DXGUI.Multiplayer;
@@ -69,6 +69,15 @@
             Window.Title = string.IsNullOrEmpty(windowTitle) ?
                 string.Format("{0} Client", MainClientConstants.GAME_NAME_SHORT) : windowTitle;
 
+            {
+                string developBuildTitle = "Development Build".L10N("Client:Main:DevelopmentBuildTitle");
+
+#if DEVELOPMENT_BUILD
+                if (ClientConfiguration.Instance.ShowDevelopmentBuildWarnings)
+                    Window.Title += $" ({developBuildTitle})";
+#endif
+            }
+
             base.Initialize();
 
             AssetLoader.Initialize(GraphicsDevice, content);

DXMainClient/DXGUI/Multiplayer/CnCNet/CnCNetLobby.cs

@@ -556,10 +556,27 @@ private void PostUIInit()
 
             gameCreationPanel.Hide();
 
+            string clientVersion = Assembly.GetExecutingAssembly().GetName().Version.ToString();
+#if DEVELOPMENT_BUILD
+            clientVersion = $"{ThisAssembly.Git.Branch}@{ThisAssembly.Git.Sha}";
+#endif
+
             connectionManager.MainChannel.AddMessage(new ChatMessage(Color.White, Renderer.GetSafeString(
-                    string.Format("*** DTA CnCNet Client version {0} ***".L10N("Client:Main:CnCNetClientVersionMessage"), Assembly.GetAssembly(typeof(CnCNetLobby)).GetName().Version),
+                    string.Format("*** DTA CnCNet Client version {0} ***".L10N("Client:Main:CnCNetClientVersionMessage"), clientVersion),
                     lbChatMessages.FontIndex)));
 
+            {
+                string developBuildWarningMessage = "This is a development build of the client. Stability and reliability may not be fully guaranteed.".L10N("Client:Main:DevelopmentBuildWarning");
+
+#if DEVELOPMENT_BUILD
+                if (ClientConfiguration.Instance.ShowDevelopmentBuildWarnings)
+                {
+                    connectionManager.MainChannel.AddMessage(new ChatMessage(Color.Red, Renderer.GetSafeString(
+                            developBuildWarningMessage, lbChatMessages.FontIndex)));
+                }
+#endif
+            }
+
             connectionManager.BannedFromChannel += ConnectionManager_BannedFromChannel;
 
             loginWindow = new CnCNetLoginWindow(WindowManager);

DXMainClient/DXMainClient.csproj

@@ -34,6 +34,10 @@
     <PackageReference Include="OpenMcdf" />
     <PackageReference Include="System.Management" />
     <PackageReference Include="System.DirectoryServices" />
+    <PackageReference Include="ThisAssembly.Git">
+      <PrivateAssets>all</PrivateAssets>
+      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+    </PackageReference>
   </ItemGroup>
   <ItemGroup>
     <ProjectReference Include="..\DTAConfig\DTAConfig.csproj" />

DXMainClient/PreStartup.cs

@@ -90,8 +90,18 @@ public static void Initialize(StartupParams parameters)
             MainClientConstants.Initialize();
 
             Logger.Log("***Logfile for " + MainClientConstants.GAME_NAME_LONG + " client***");
-            Logger.Log("Client version: " + Assembly.GetAssembly(typeof(PreStartup)).GetName().Version);
-            Logger.Log(FileVersionInfo.GetVersionInfo(Assembly.GetExecutingAssembly().Location).ProductVersion);
+
+            string clientVersion = Assembly.GetExecutingAssembly().GetName().Version.ToString();
+#if DEVELOPMENT_BUILD
+            clientVersion = $"{ThisAssembly.Git.Branch}@{ThisAssembly.Git.Sha}";
+#endif
+
+            Logger.Log($"Client version: {clientVersion}");
+            Logger.Log(Assembly.GetExecutingAssembly().GetCustomAttribute<AssemblyInformationalVersionAttribute>().InformationalVersion);
+
+#if DEVELOPMENT_BUILD
+            Logger.Log("This is a development build of the client. Stability and reliability may not be fully guaranteed.");
+#endif
 
             // Log information about given startup params
             if (parameters.NoAudio)

DXMainClient/Resources/ClientDefinitions.ini

@@ -106,3 +106,7 @@ Quickmatch=CnCNetQM.exe
 
 ; Set to true to disable the updater and to hide the "cheater!" dialog when modding the game
 ModMode=true
+
+; Activates warnings for non-release build of XNA Client. 
+; Please, make sure you are not publishing stable mod version with unstable development client build. 
+ShowDevelopmentBuildWarnings=true

Directory.Build.props

@@ -10,6 +10,8 @@
     <Product>CnCNet Client</Product>
     <Copyright>Copyright © CnCNet, Rampastring 2011-2024</Copyright>
     <Trademark>CnCNet</Trademark>
+    <!-- GitVersion will rewrite the informational version anyway -->
+    <IncludeSourceRevisionInInformationalVersion>false</IncludeSourceRevisionInInformationalVersion>
   </PropertyGroup>
 
   <PropertyGroup>

Directory.Build.targets

@@ -3,6 +3,14 @@
     <Message Importance="high" Text="Engine: $(Engine); Game: $(Game); Platform: $(Platform); TargetFramework: $(TargetFramework); Configuration: $(Configuration)" />
   </Target>
 
+  <!-- "GetVersion" target is defined in GitVersion package -->
+  <Target Name="NonReleaseBuildWarning" AfterTargets="GetVersion" Condition="'$(MSBuildProjectName)' == 'DXMainClient' AND ($(GitVersion_CommitsSinceVersionSource) != 0 OR $(GitVersion_BranchName) != 'master')">
+    <PropertyGroup>
+      <DefineConstants>$(DefineConstants);DEVELOPMENT_BUILD</DefineConstants>
+    </PropertyGroup>
+    <Warning Text="This is a development build of the client. Stability and reliability may not be fully guaranteed." Condition="'$(BuildingInsideVisualStudio)' != 'true'"></Warning>
+  </Target>
+
   <Target Name="RestoreUpdater" AfterTargets="Restore" Condition="'$(PublishDir)' != '' AND '$(MSBuildProjectName)' == 'DXMainClient'">
     <MSBuild
       Projects="$(MSBuildThisFileDirectory)SecondStageUpdater\SecondStageUpdater.csproj"

Directory.Packages.props

@@ -28,6 +28,7 @@
     <PackageVersion Include="System.DirectoryServices" Version="$(DotnetLibrariesVersion)" />
     <PackageVersion Include="System.Management" Version="$(DotnetLibrariesVersion)" />
     <PackageVersion Include="System.Text.Encoding.CodePages" Version="$(DotnetLibrariesVersion)" />
+    <PackageVersion Include="ThisAssembly.Git" Version="2.0.6" />
   </ItemGroup>
   <ItemGroup Condition="'$(MSBuildProjectName)' == 'ClientCore' Or '$(MSBuildProjectName)' == 'ClientGUI' Or '$(MSBuildProjectName)' == 'DTAConfig' Or '$(MSBuildProjectName)' == 'DXMainClient'">
     <ProjectReference Include="$(MSBuildThisFileDirectory)TranslationNotifierGenerator\TranslationNotifierGenerator.csproj" OutputItemType="Analyzer" ReferenceOutputAssembly="false" />

GitVersion.yml

@@ -18,8 +18,8 @@
 # base tag of "2.8.0-beta.1" is also a beta.
 # 
 # Latest tag is "2.8.0" -
-# A new commit is added directly to master. The new version is "2.8.1".
-# That increments th Patch, because it is treated as a "hotfix" directly on master.
+# A new commit is added directly to master. The new version is "2.8.1-rc.1".
+# That increments the Patch, because it is treated as a "hotfix" directly on master.
 #
 # Versioning Modes Quick View:
 # 
@@ -37,7 +37,7 @@ branches:
     increment: Patch
     is-mainline: true
     source-branches: [ 'develop' ]
-    tag: ''
+    tag: rc
 
   develop:
     regex: ^develop$