Translation system config reading fix #997
Annotations
10 warnings
Build Ares:
ClientCore/OSVersion.cs#L1
Declare types in namespaces (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1050)
|
Build Ares:
ClientCore/Enums/AllowPrivateMessagesFromEnum.cs#L3
Rename type name AllowPrivateMessagesFromEnum so that it does not end in 'Enum' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711)
|
Build Ares:
ClientCore/SavedGameManager.cs#L15
Member 'saveRenameInProgress' is explicitly initialized to its default value (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1805)
|
Build Ares:
ClientCore/CnCNet5/GameCollection.cs#L15
Rename type name GameCollection so that it does not end in 'Collection' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711)
|
Build Ares:
ClientCore/CnCNet5/NameValidator.cs#L24
Prefer 'AsSpan' over 'Substring' when span-based overloads are available (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1846)
|
Build Ares:
ClientCore/ClientConfiguration.cs#L239
The behavior of 'int.ToString()' could vary based on the current user's locale settings. Replace this call in 'ClientConfiguration.GetThemeInfoFromIndex(int)' with a call to 'int.ToString(IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
Build Ares:
ClientCore/ClientConfiguration.cs#L292
Prefer using 'string.Equals(string, StringComparison)' to perform a case-insensitive comparison, but keep in mind that this might cause subtle changes in behavior, so make sure to conduct thorough testing after applying the suggestion, or if culturally sensitive comparison is not required, consider using 'StringComparison.OrdinalIgnoreCase' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1862)
|
Build Ares:
ClientCore/ClientConfiguration.cs#L298
Prefer using 'string.Equals(string, StringComparison)' to perform a case-insensitive comparison, but keep in mind that this might cause subtle changes in behavior, so make sure to conduct thorough testing after applying the suggestion, or if culturally sensitive comparison is not required, consider using 'StringComparison.OrdinalIgnoreCase' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1862)
|
Build Ares:
ClientCore/ClientConfiguration.cs#L284
The behavior of 'string.StartsWith(string)' could vary based on the current user's locale settings. Replace this call in 'ClientCore.ClientConfiguration.ParseTranslationGameFiles()' with a call to 'string.StartsWith(string, System.StringComparison)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1310)
|
Build Ares:
ClientCore/ClientConfiguration.cs#L385
Member 'GetOperatingSystemVersion' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)
|
Loading