Improve python example #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the new default for most distro (Python3), make it OO-based rather than sequentially scripted, make it runnable, improve API, etc.
There was no way this could work before without manual volume mounting and now we use Python3 as well.
This will be the basis for creating a simple REST API client for flocker since other tools are either more complicated or have no good way to install them.
This should make things easier when reusing this code to create volumes.
We can now get this data without specifying the endpoint
We need this to ensure consistency of the cluster.
This allows the api to now easily moves volumes around on nodes.
This also needed to be added as there was no easy way to get it without hardcoded strings.
This should round out the API for REST.
Since we don't do any CLI processing, this is effectively still just an example of API usage.
This should do most of the things that we want through CLI params though we still need to add the things we infer from the env vars.
This should be a bit more intuitive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new default for most distro (Python3), make it OO-based rather than
sequentially scripted, make it runnable, improve API, etc.