Adding new example: Docker Registry #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
November 4, 2016 18:35
… example-registry
wallnerryan
reviewed
Nov 15, 2016
| ports: | ||
| - 5000 | ||
| volumes: | ||
| - /denverimaging/e3ebf132-c720-4d33-afe0-7b858eb88cdd/3dc9dd9a-802f-4dee-83dc-955f32165f08:/var/lib/registry |
There was a problem hiding this comment.
Should this path be in here? Think this should be registry-mount
wallnerryan
reviewed
Nov 15, 2016
|
|
||
| flocker_hub: | ||
| endpoint: https://data.flockerhub.clusterhq.com | ||
| tokenfile: /root/vhut.txt |
wallnerryan
reviewed
Nov 15, 2016
| set -e | ||
|
|
||
| function fli () { | ||
| local zpool_name='denverimaging' |
There was a problem hiding this comment.
This should probably be configurable, as they may not want or have this as a zpool name
wallnerryan
reviewed
Nov 15, 2016
| docker run --rm -it --privileged -v /etc/hosts:/etc/hosts -v /root:/root -v /${zpool_name}:/${zpool_name}:shared -v /var/log/fli:/var/log/fli -v /lib/modules:/lib/modules quay.io/clusterhq_prod/fli:c6a5deac3bb68b93341c8accfdde66fd7d13fc1f "$@" | ||
| } | ||
|
|
||
| ### Set a unique VOlumeSet and Volume name |
There was a problem hiding this comment.
where are these used. Not seeing where volumeset_name, volume_name or snapshot_name is used?
|
hey @pcgeek86 let me know if you want to address the above comments and get your example in. happy to have it. |
|
@wallnerryan Yeah I will update it at some point. I think I made the changes somewhere, but never committed and/or pushed them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.