Fix the inability to override commands #2196
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it is impossible to unregister a command using this method:
command.unregister()
returnsfalse
becauseCommand.allowChangesFrom()
returnsfalse
. As old code shows, acommandMap
passed as parameter should NOT be null (which is passes fine), and it should NOT be equal to command's known command map (this.commandMap
), this sounds as complete nonsense because command SHOULD allow changes from acommandMap
that is equal tothis.commandMap
and vice-versa. (Vanilla commands are all registered using sameSimpleCommandMap
instance so it should always returntrue
when comparingthis.commandMap
toServer.getInstance().getCommandMap()
, right?P.S.
Also, this should prove my point.
https://github.com/pmmp/PocketMine-MP/blob/stable/src/command/Command.php#L176
(referred issue: unregister commands not working #2145)