This repository has been archived by the owner on Jun 7, 2022. It is now read-only.
Complete revision of the module system #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Pull Request
Add basic model structure.
Fix some issues about new module system.
|
The loading of the modules was tested. The order should be as follows:
|
|
This pull request introduces 1 alert when merging e09cc49 into e5f21bf - view on LGTM.com new alerts:
|
GiantTreeLP
suggested changes
Jun 7, 2020
There was a problem hiding this comment.
There are a few more changes I may have missed to mark.
All in all not bad, a few things should be done differently though, in order to reduce coupling of classes and improving cohesion (https://sites.google.com/site/koesterprogramming/home/softwareentwicklung/kohaesion-und-kopplung)
...net-master/src/main/java/eu/cloudnetservice/cloudnet/v2/master/module/ModuleClassLoader.java
Outdated
Show resolved
Hide resolved
...main/java/eu/cloudnetservice/cloudnet/v2/master/module/model/CloudModuleDescriptionFile.java
Outdated
Show resolved
Hide resolved
...main/java/eu/cloudnetservice/cloudnet/v2/master/module/model/CloudModuleDescriptionFile.java
Outdated
Show resolved
Hide resolved
Improve initialization of JavaCloudModule. Make type token into a constant. Make on CloudModuleDescriptionFile some fields into interface.
GiantTreeLP
suggested changes
Jun 8, 2020
...net-master/src/main/java/eu/cloudnetservice/cloudnet/v2/master/module/CloudModuleLogger.java
Outdated
Show resolved
Hide resolved
...et-master/src/main/java/eu/cloudnetservice/cloudnet/v2/master/module/CloudModuleManager.java
Outdated
Show resolved
Hide resolved
...et-master/src/main/java/eu/cloudnetservice/cloudnet/v2/master/module/CloudModuleManager.java
Outdated
Show resolved
Hide resolved
...et-master/src/main/java/eu/cloudnetservice/cloudnet/v2/master/module/CloudModuleManager.java
Outdated
Show resolved
Hide resolved
...et-master/src/main/java/eu/cloudnetservice/cloudnet/v2/master/module/CloudModuleManager.java
Outdated
Show resolved
Hide resolved
...et-master/src/main/java/eu/cloudnetservice/cloudnet/v2/master/module/CloudModuleManager.java
Outdated
Show resolved
Hide resolved
...et-master/src/main/java/eu/cloudnetservice/cloudnet/v2/master/module/CloudModuleManager.java
Outdated
Show resolved
Hide resolved
...et-master/src/main/java/eu/cloudnetservice/cloudnet/v2/master/module/CloudModuleManager.java
Outdated
Show resolved
Hide resolved
...et-master/src/main/java/eu/cloudnetservice/cloudnet/v2/master/module/CloudModuleManager.java
Outdated
Show resolved
Hide resolved
...et-master/src/main/java/eu/cloudnetservice/cloudnet/v2/master/module/CloudModuleManager.java
Outdated
Show resolved
Hide resolved
…aster/module/CloudModuleLogger.java Co-authored-by: Marvin <[email protected]>
…aster/module/CloudModuleManager.java Co-authored-by: Marvin <[email protected]>
…aster/module/CloudModuleManager.java Co-authored-by: Marvin <[email protected]>
…aster/module/CloudModuleManager.java Co-authored-by: Marvin <[email protected]>
…aster/module/CloudModuleManager.java Co-authored-by: Marvin <[email protected]>
Co-authored-by: Marvin <[email protected]>
Update java documentation.
Fix some import. Replace CopyOnWriteArrayList. Remove some not necessaries final parameters.
Fix imports.
GiantTreeLP
suggested changes
Jun 9, 2020
...et-master/src/main/java/eu/cloudnetservice/cloudnet/v2/master/module/CloudModuleManager.java
Outdated
Show resolved
Hide resolved
Remove unused exceptions. Add notnull annotations. Remove not necessary finals.
derklaro
suggested changes
Jun 10, 2020
...mples/src/main/java/eu/cloudnetservice/cloudnet/v2/examples/module/ExampleModuleCommand.java
Show resolved
Hide resolved
cloudnet-master/src/main/java/eu/cloudnetservice/cloudnet/v2/master/CloudConfig.java
Show resolved
Hide resolved
GiantTreeLP
approved these changes
Jun 10, 2020
|
Alright, merging. Keep in mind that all modules need to be adapted to this new API. |
11 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this Pull Request the complete module system was revised. Circular dependencies should no longer be a problem in the future. Also an extended API was made available to allow developers to better integrate the system. It was built very similar to Bukkit and the Spigot API.
Missing functions are the Observe Pattern for Auto Update and the Event for FileDeployment into the Cloud.
Also the CloudAPI load bug was fixed because of the renaming of the pack.
And there are a few places where an improved exception handling was done.
And yes, the code needs to be more ordered or made more beautiful and also the description needs to be added.