-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature to disable private submission #4419
base: master
Are you sure you want to change the base?
Conversation
Harshit28j
commented
Aug 31, 2024
•
edited
Loading
edited
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4419 +/- ##
==========================================
- Coverage 72.93% 68.91% -4.02%
==========================================
Files 83 20 -63
Lines 5368 3600 -1768
==========================================
- Hits 3915 2481 -1434
+ Misses 1453 1119 -334
... and 63 files with indirect coverage changes
... and 63 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR!
In submission.html, make sure that this thing is disabled when the private submissions are disabled. i.e. don't give this option during submission.
In my-submission page, there is a bunch of logic here which shows a column to make an old/existing submission public or private. That column should only be visible when disable_private_submission
is False:
Also, make sure to understand the logic here before making changes, will help with a sanity check.
Test it out locally using ngrok.
Try enable/disable using the config. And enable/disable using the edit option that you have added.
And add screenshot of the submit tab and my-submissions page in all four cases.
And a good to have: add this attribute to challenge config docs: https://evalai.readthedocs.io/en/latest/configuration.html
@gchhablani I have also tested this by hosting a challenge from EvalAI-Starters using challenge_config.yaml, adding the |
@Harshit28j Can you share screenshot of the my submissions page too? |
@gchhablani here: |
Hello all, We’re hosting a challenge at the end of this month, and this feature would make a big difference. In past editions, everyone kept their submissions private, which left the leaderboard outdated and discouraged competition. Disabling private submissions will keep the leaderboard active and make the event more engaging. Could you help speed up the review of this pull request? It’s exactly what we need for this challenge! Thanks a lot! |