주문 통합테스트 구현 #23
Merged
주문 통합테스트 구현 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axhtl
force-pushed
the
test/order-integration
branch
2 times, most recently
from
fc5f18c to
75b966a
Compare
axhtl
force-pushed
the
test/order-integration
branch
from
49df33c to
f79a989
Compare
upswp
suggested changes
Aug 21, 2024
Comment on lines
+121
to
+127
| actions.andExpect(status().isOk()) | ||
| .andExpect(jsonPath("$.message").value("주문이 정상적으로 취소되었습니다.")) | ||
|
|
||
| // 데이터베이스에서 주문 상태 조회하여 검증 | ||
| val savedOrder: Order? = orderRepository.findByIdOrNull(order.orderId) | ||
| assertNotNull(savedOrder) | ||
| assertEquals(Status.CANCELED, savedOrder.status) |
|
|
||
| // 데이터베이스에서 주문 상태 조회하여 검증 | ||
| val savedOrder: Order? = orderRepository.findByIdOrNull(order.orderId) | ||
| assertNotNull(savedOrder) |
There was a problem hiding this comment.
null 체크를 하는 부분보다 객체에서 확인하고싶은 부분을 보시는게 좋습니다!
Comment on lines
+98
to
+99
| actions.andExpect(status().isOk()) | ||
| .andExpect(jsonPath("$.message").value("주문이 정상적으로 출고처리되었습니다.")) |
| // 데이터베이스에서 주문 상태 조회하여 검증 | ||
| val savedOrder: Order? = orderRepository.findByIdOrNull(order.orderId) | ||
| assertNotNull(savedOrder) | ||
| assertEquals(Status.PROCESSING, savedOrder.status) |
Comment on lines
+93
to
+96
| //then | ||
| actions | ||
| .andExpect(status().isOk) | ||
| .andExpect(jsonPath("$.orderId").value(orderId)) |
There was a problem hiding this comment.
조회의 특성을 살려 어떤 값을 조회했는지 예상한 값이 조회되었는지도 같이 작성되면 좋겠습니다.
Comment on lines
99
to
133
| @DisplayName("전체 주문 조회 offset 페이징 통합테스트") | ||
| @Test | ||
| fun testGetAllOrderOffsetPaging() { | ||
| //given | ||
| //필요한 데이터 생성(여러 주문 추가) | ||
| createOrders(110) | ||
|
|
||
| //when | ||
| val actions: ResultActions = mockMvc.perform( | ||
| MockMvcRequestBuilders.get(ORDER_URL + "/offset") | ||
| .contentType(MediaType.APPLICATION_JSON) | ||
| ) | ||
|
|
||
| //then | ||
| actions.andExpect(status().isOk()) | ||
| .andExpect(jsonPath("$.content.length()").value(10)) | ||
| } | ||
|
|
||
| @DisplayName("전체 주문 조회 slice 페이징 통합테스트") | ||
| @Test | ||
| fun testGetAllOrderSlicePaging() { | ||
| //given | ||
| //필요한 데이터 생성(여러 주문 추가) | ||
| createOrders(110) | ||
|
|
||
| //when | ||
| val actions: ResultActions = mockMvc.perform( | ||
| MockMvcRequestBuilders.get(ORDER_URL + "/slice") | ||
| .contentType(MediaType.APPLICATION_JSON) | ||
| ) | ||
|
|
||
| //then | ||
| actions.andExpect(status().isOk()) | ||
| .andExpect(jsonPath("$.content.length()").value(10)) | ||
| } |
| // 데이터베이스에서 주문 조회하여 삭제 여부 검증 | ||
| val savedOrder: Order? = orderRepository.findByIdOrNull(order.orderId) | ||
| assertNotNull(savedOrder) | ||
| assertNotNull(savedOrder.deletedAt) |
- then 부분에는 기대하는 결과값에 대해서만 작성 - offset과 slice의 특징이 나타나도록 테스트 검증 (findAllByOrderByOrderIdDesc() 메서드 추가) - 주문 삭제에서 시간값을 비교하는 부분 추가
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
통합 테스트를 구현하였습니다.
OrderSeller
OrderUser