Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added symbolPrefix #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added symbolPrefix #3

wants to merge 1 commit into from

Conversation

epikhighs
Copy link

allowing a prefix to the symbol IDs was an option in the other SVG libs I used. So I thought I'd add one here.

@Climenty
Copy link
Owner

@epikhighs, what about using the same CSS prefix (svg_) for symbol naming?
Or does your use case require a different option?

@epikhighs
Copy link
Author

I thought about that, but there's a default value for css prefix that seemed to be applied even if i don't specify the css prefix option. So then, that would change the behavior to warrant a major version bump right? This solution would keep backwards compatibility.

but yeah, I would think that most people would use the same prefix for css and svg Ids

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants