Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate duplicate universal_func_type and generalize parameter extractor functions #149

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

glwagner
Copy link
Member

@glwagner glwagner commented Jan 11, 2024

This PR eliminates the duplicate universal_func_type by properly extending UniversalFunctions.universal_func_type within the Parameters submodule.

It also generalizes the parameter extractor functions to make it easier to build user-defined AbstractSurfaceFluxesParameters.

Closes #145

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: Patch coverage is 15.38462% with 11 lines in your changes missing coverage. Please review.

Project coverage is 90.05%. Comparing base (4f06b46) to head (4f222bf).
Report is 25 commits behind head on main.

Files Patch % Lines
src/Parameters.jl 15.38% 11 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #149   +/-   ##
=======================================
  Coverage   90.05%   90.05%           
=======================================
  Files           4        4           
  Lines         835      835           
=======================================
  Hits          752      752           
  Misses         83       83           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There are two distinct universal_func_types
2 participants