Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for GLSG21 Eq. 2 and Eq. 3 #104

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Added tests for GLSG21 Eq. 2 and Eq. 3 #104

merged 1 commit into from
Aug 7, 2023

Conversation

gdecker1
Copy link
Contributor

@gdecker1 gdecker1 commented Jul 17, 2023

Purpose

Add edge case tests for Gryanik (2021) Eq. 2 and Eq. 3 to existing test set.


  • I have read and checked the items on the review checklist.

@gdecker1 gdecker1 self-assigned this Jul 17, 2023
@gdecker1 gdecker1 added the Tests label Jul 17, 2023
@cmbengue cmbengue linked an issue Jul 18, 2023 that may be closed by this pull request
@cmbengue cmbengue added this to the Universal function upgrade milestone Jul 18, 2023
@gdecker1 gdecker1 marked this pull request as ready for review July 24, 2023 17:33
@akshaysridhar
Copy link
Member

@gdecker1 if you can update+rebase this branch we can merge this.

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (fdeeaba) 81.83% compared to head (77c739b) 81.83%.

❗ Current head 77c739b differs from pull request most recent head d96a19c. Consider uploading reports for the commit d96a19c to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #104   +/-   ##
=======================================
  Coverage   81.83%   81.83%           
=======================================
  Files           3        3           
  Lines         523      523           
=======================================
  Hits          428      428           
  Misses         95       95           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akshaysridhar
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 7, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit ca78057 into main Aug 7, 2023
8 checks passed
@bors bors bot deleted the gd/profile_edge_cases branch August 7, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementation of New Universal Functions
3 participants