Restores open boundary condition functionality #3937
+98
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
shoudl we add a test to make sure it keeps working? |
|
a test is a good idea. |
| @@ -61,7 +61,7 @@ end | |||
|
|
|||
| const c = Center() | |||
|
|
|||
| @inline function _fill_west_open_halo!(j, k, grid, ϕ, bc::FEOBC, loc, clock, model_fields) | |||
| @inline function _fill_west_halo!(j, k, grid, ϕ, bc::FEOBC, loc, clock, model_fields) | |||
| Δx₁ = xspacing(1, j, k, grid, c, c, c) | |||
There was a problem hiding this comment.
Suggested change
| Δx₁ = xspacing(1, j, k, grid, c, c, c) | |
| Δx₁ = Δxᶜᶜᶜ(1, j, k, grid) |
Probably better to use the pointwise operators from here (and in the rest of this file)
navidcy
changed the title
jagoosw
changed the title
|
I might be missing something but I think that the changes in #3834 make it so that open halos are filled even when Edit: I have now added it |
jagoosw
commented
Dec 6, 2024
| # Returns the boundary conditions a specific side for `FieldBoundaryConditions` inputs and | ||
| # a tuple of boundary conditions for `NTuple{N, <:FieldBoundaryConditions}` inputs | ||
| for dir in (:west, :east, :south, :north, :bottom, :top) | ||
| extract_side_bc = Symbol(:extract_, dir, :_bc) | ||
| @eval begin | ||
| @inline $extract_side_bc(bc) = bc.$dir | ||
| @inline $extract_side_bc(bc) = retrieve_bc(bc.$dir) |
There was a problem hiding this comment.
@simone-silvestri I think we need this analogously to retrieve_open_bc
jagoosw
added
bug 🐞
|
@glwagner @simone-silvestri I think this should be all done now and we should merge ASAP since open boundaries are currently broken |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refactoring in #3834 broke flat extrapolation open boundary conditions. This restores them.
Closes #3975