Skip to content

Commit

Permalink
(0.95.2) Bugfix in the Polar BC (#3985)
Browse files Browse the repository at this point in the history
* bugfix

* bump

* tests

* Update Project.toml

---------

Co-authored-by: Gregory L. Wagner <[email protected]>
  • Loading branch information
simone-silvestri and glwagner authored Dec 13, 2024
1 parent dddd531 commit 2b4d16a
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "Oceananigans"
uuid = "9e8cae18-63c1-5223-a75c-80ca9d6e9a09"
authors = ["Climate Modeling Alliance and contributors"]
version = "0.95.1"
version = "0.95.2"

[deps]
Adapt = "79e6a3ab-5dfb-504d-930d-738a2a938a0e"
Expand Down
6 changes: 5 additions & 1 deletion src/BoundaryConditions/polar_boundary_condition.jl
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using Oceananigans.Grids: inactive_node, new_data
using Oceananigans.Grids: inactive_node, new_data, YFlatGrid
using CUDA: @allowscalar

struct PolarValue{D, S}
Expand All @@ -20,6 +20,10 @@ end
# Just a column
@inline getbc(pv::BC{<:Value, <:PolarValue}, i, k, args...) = @inbounds pv.condition.data[1, 1, k]

# YFlat grids do not have boundary conditions!
latitude_north_auxiliary_bc(::YFlatGrid, args...) = nothing
latitude_south_auxiliary_bc(::YFlatGrid, args...) = nothing

# TODO: vectors should have a different treatment since vector components should account for the frame of reference.
# For the moment, the `PolarBoundaryConditions` is implemented only for fields that have `loc[1] == loc[2] == Center()`, which
# we assume are not components of horizontal vectors that would require rotation. (The `w` velocity if not a tracer, but it does
Expand Down

2 comments on commit 2b4d16a

@glwagner
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/121374

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.95.2 -m "<description of version>" 2b4d16a455dc0ed05b695cdd749ceef57f3e0d77
git push origin v0.95.2

Please sign in to comment.