Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Isolate config and argument parsing #1086

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Isolate config and argument parsing #1086

wants to merge 9 commits into from
+512 −321

Commits on Nov 25, 2024

  1. add functions for config/arg parsing 

    This commit isolates the argument and configuration file parsing to functions. Since we have one configuration file each for the coupled simulation and for the atmosphere, we end up with the following functions, as well as smaller helper functions. These are located in the new `experiments/ClimaEarth/arg_parsing.jl file`.
- `get_coupler_config`, `get_coupler_args`, `get_atmos_args`

These functions are called from the driver `run_amip.jl`, where the returned arguments are unpacked. After that point, the config files are not accessed further down in the driver, so we have isolated the config file access to the initial step.
    @juliasloan25
    juliasloan25 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    290f927 View commit details
    Browse the repository at this point in the history

  2. don't modify coupler config in get_atmos_config_dict

    @juliasloan25
    juliasloan25 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    9710d83 View commit details
    Browse the repository at this point in the history

  3. make t_start optional argument

    @juliasloan25
    juliasloan25 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    25c0220 View commit details
    Browse the repository at this point in the history

  4. unify arg_parsing and cli_options

    @juliasloan25
    juliasloan25 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    f664acc View commit details
    Browse the repository at this point in the history

  5. use nothing for restart_dir default

    @juliasloan25
    juliasloan25 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    f8ce4b9 View commit details
    Browse the repository at this point in the history

  6. use time format convention for dt_cpl

    @juliasloan25
    juliasloan25 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    415cd77 View commit details
    Browse the repository at this point in the history

  7. rename diagnostics -> extra_atmos_diagnostics

    @juliasloan25
    juliasloan25 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    a6c5f71 View commit details
    Browse the repository at this point in the history

  8. rename CI plots -> diagnostics plots

    @juliasloan25
    juliasloan25 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    570dbbf View commit details
    Browse the repository at this point in the history

  9. add config_file, job_id defaults

    @juliasloan25
    juliasloan25 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    90d1c2a View commit details
    Browse the repository at this point in the history