Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Plots usage with Makie #1097

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

imreddyTeja
Copy link
Contributor

@imreddyTeja imreddyTeja commented Nov 22, 2024

All uses of Plots and ClimaCorePlots are removed in this commit. For almost all of the generated plots, the Makie version is visually similar to the Plots.jl versions.

Due to a limitation of Makie, the sea_breeze output animations are slightly different. The Plots.jl animations had a colorbar and levels that rescaled each frame. This commit makes the animations use a consistent colorbar and levels.

Plots and ClimaCorePlots are removed from Project.toml of both experiments/ClimaEarth and experiments/ClimaCore.

Some of the contour plots look slightly different due to differences in Makie and Plots.jl graphics, and because the default behavior of ClimaCoreMakie is to use viridis.

Purpose

Closes #1091

To-do

  • update manifests?
  • double check build kite artifacts vs an old buildkite-ci run

Content


  • I have read and checked the items on the review checklist.

@imreddyTeja imreddyTeja force-pushed the tr/remove-Plots.jl-usage branch 4 times, most recently from 7d033b8 to 63dc1db Compare November 23, 2024 00:47
All uses of Plots and ClimaCorePlots are removed in this commit.
For almost all of the generated plots, the Makie version is
visually similar to the Plots.jl versions.

Due to a limitation of Makie, the sea_breeze output animations
are slightly different. The Plots.jl animations had a colorbar and levels
that rescaled each frame. This commit makes the animations use a
consistent colorbar and levels.

Plots and ClimaCorePlots are removed from Project.toml of both
experiments/ClimaEarth and experiments/ClimaCore.

Some of the contour plots look slightly different due to
differences in Makie and Plots.jl graphics, and because the default
behavior of ClimaCoreMakie is to use viridis.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Plots.jl dependency
1 participant