Replace Plots usage with Makie #1097
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imreddyTeja
force-pushed
the
tr/remove-Plots.jl-usage
branch
6 times, most recently
from
73d2dd3
to
6cdf73f
Compare
imreddyTeja
commented
Nov 25, 2024
| @@ -83,7 +83,7 @@ plot_field_names(sim::Interfacer.SurfaceStub) = (:stub_field,) | |||
| ) | |||
|
|
|||
| output_plots = "test_debug" | |||
| @test_logs (:info, "plotting debug in test_debug") debug(cs, output_plots) | |||
| @test_logs (:info, "plotting debug in test_debug") match_mode = :any debug(cs, output_plots) | |||
There was a problem hiding this comment.
I added this because ClimaCoreMakie.fieldheatmap throws a warning because of an invalid attribute. I fixed the warning in ClimaCoreMakie, so this could be removed eventually
imreddyTeja
force-pushed
the
tr/remove-Plots.jl-usage
branch
5 times, most recently
from
b7beec5
to
d86611e
Compare
All uses of Plots and ClimaCorePlots are removed in this commit. For almost all of the generated plots, the Makie version is visually similar to the Plots.jl versions. Due to a limitation of Makie, the sea_breeze output animations are slightly different. The Plots.jl animations had a colorbar and levels that rescaled each frame. This commit makes the animations use a consistent colorbar and levels. Plots and ClimaCorePlots are removed from Project.toml of both experiments/ClimaEarth and experiments/ClimaCore. Some of the contour plots look slightly different due to differences in Makie and Plots.jl graphics, and because the default behavior of ClimaCoreMakie is to use viridis.
Update v1.11 manifests
Using ClimaCoreMakie.fieldheatmap or fieldheatmap! throws a warning because of an invalid attribute. I fixed this in ClimaCoreMakie, but until the next release, this allows other log messages in the test.
imreddyTeja
force-pushed
the
tr/remove-Plots.jl-usage
branch
from
d86611e
to
c0cd753
Compare
juliasloan25
approved these changes
Nov 27, 2024
| @@ -8,6 +8,7 @@ ClimaAnalysis = "29b5916a-a76c-4e73-9657-3c8fd22e65e6" | |||
| ClimaAtmos = "b2c96348-7fb7-4fe0-8da9-78d88439e717" | |||
| ClimaComms = "3a4d1b5c-c61d-41fd-a00a-5873ba7a1b0d" | |||
| ClimaCore = "d414da3d-4745-48bb-8d80-42e94e092884" | |||
| ClimaCoreMakie = "908f55d8-4145-4867-9c14-5dad1a479e4d" | |||
| ClimaCorePlots = "cf7c7e5a-b407-4c48-9047-11a94a308626" | |||
There was a problem hiding this comment.
Can we remove ClimaCorePlots and Plots from the test environment now too?
There was a problem hiding this comment.
I see that we have some commented-out plotting lines in regridder_tests.jl. It's fine to remove those lines since they're not being used and we want to switch to ClimaUtilities regridding soon anyway. That might be the only place we use Plots/ClimaCorePlots in test/
| import Plots | ||
| Plots.GRBackend() | ||
| import Makie | ||
| import CairoMakie | ||
|
|
||
| ARTIFACTS_DIR = joinpath("experiments/ClimaCore/output/heat-diffusion_artifacts") |
There was a problem hiding this comment.
There are no artifacts on buildkite for the heat diffusion run because this should be "/heat-diffusion/artifacts", but after rebasing on main it should be fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All uses of Plots and ClimaCorePlots are removed in this commit. For almost all of the generated plots, the Makie version is visually similar to the Plots.jl versions.
Due to a limitation of Makie, the sea_breeze output animations are slightly different. The Plots.jl animations had a colorbar and levels that rescaled each frame. This commit makes the animations use a consistent colorbar and levels.
Plots and ClimaCorePlots are removed from Project.toml of both experiments/ClimaEarth and experiments/ClimaCore.
Some of the contour plots look slightly different due to differences in Makie and Plots.jl graphics, and because the default behavior of ClimaCoreMakie is to use viridis.
Purpose
Closes #1091
To-do
Content