Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "dissoluted devourer" to "dissolving devourer" #79237

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

autarch
Copy link

@autarch autarch commented Jan 19, 2025

Summary

None

Purpose of change

The word "dissoluted" has several problems. First, it's not a word, because "dissolute" is an adjective, not a verb. Second, "dissolute" means "debauched", not "dissolving" or "dissolved".

Describe the solution

I renamed this to "dissolving devourer".

Additional context

I think there are a few other names that could work:

  • dissolved devourer
  • melted devourer
  • melting devourer

And more along those lines. I think "dissolving" is good, but I'm fine with of these choices.

Copy link
Contributor

It appears you modified a .po or .pot file. These translation files are automatically generated, pushed to, and pulled from Transifex, and should not be modified otherwise. If these changes are intended, please add Translation file changes are intended to the PR body.

@Bone-blood-moss
Copy link

Dissoluted works better zombies Dissolved into it and all. it tells you what the and what's happening and what it does.

@autarch
Copy link
Author

autarch commented Jan 19, 2025

Dissoluted works better zombies Dissolved into it and all. it tells you what the and what's happening and what it does.

As I said, "dissoluted" is simply not a word in the English language. The word "dissolute" is an adjective, not a verb. You can add a "d" to make it past tense.

But it sounds like maybe you're saying you prefer "dissolved" over "dissolving". I'm fine with either, but the reason I picked "dissolving" is that "dissolved" makes it sound like it's already a puddle. The word "dissolving" can suggest that it's either in the process of dissolving itself or that it dissolves others, which I think is a bit better.

The word "dissoluted" had several problems. First, it's not a word, because "dissolute" is an
adjective, not a verb. Second, "dissolute" means "debauched", not "dissolving" or "dissolved".
@autarch autarch force-pushed the replace-dissoluted branch from b70a96c to 334115c Compare January 19, 2025 02:54
@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON Monsters Monsters both friendly and unfriendly. [Markdown] Markdown issues and PRs astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jan 19, 2025
@Vaskritaya
Copy link
Contributor

To me, words like "melting" and 'dissolving" bring to mind acid, which is a pretty common archetype for zombies and doesn't reflect what the devourer actually is. "dissoluted" was functionally meaningless to me and probably most others, but I'm not sure this is an improvement in clarity.

@autarch
Copy link
Author

autarch commented Jan 19, 2025

If folks like the word "dissolute" then I think the best option is to rename it to "dissolute devourer". I think it's a bit of a goofy name if you know what dissolute means, though. Is this fusion of zombies is drinking, gambling, and hanging around with people of low character in Victorian England or something?

@oosyrag
Copy link
Contributor

oosyrag commented Jan 19, 2025

There is no need to maintain alliteration.

Colossal devourer
Zombie devourer
Zombie amalgam/amalgamation
Melded zombie

I personally do not like dissolving (or dissolved) devourer at all. It implies it itself is dissolving or that it dissolves other things, neither of which are particularly suitable.

@XygenSS
Copy link
Contributor

XygenSS commented Jan 19, 2025

"zombie amalgamation" is problematic because we already have flesh-raptors and other "amalgamation" zombie monsters. Also, we have an "anatomy of amalgamations" proficiency as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Monsters Monsters both friendly and unfriendly. new contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants