Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aftershock: Direct trade of cash cards and Mercurial faction #79236

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

John-Candlebury
Copy link
Member

Summary

Mods "Aftershock: Allow direct trade of cash cards"

Purpose of change

Fix #79200
Cash cards are valid money in aftershock already, since you can use your bank balance to pay for stuff.

Describe the solution

Audited the definitions of cent and cash card item.

Created a new Mercurial faction because trade lists where merging between the postmaster and the station doctor due to proximity, and we need it anyhow.

Testing

Traded cash cards successfully.

@github-actions github-actions bot requested a review from Maleclypse January 18, 2025 23:01
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Aftershock Anything to do with the Aftershock mod <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jan 18, 2025
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • A massive, multi-system corporation specializing in genetic engineering, terraforming, and biotechnology. Before the discontinuity, it heavily invested in extrasolar colonization and the study of alien life. Theoretically it holds the planetary colonization charter for Salus IV, per UICA's constitional treaty, but the corporation's interests currently lie elsewhere.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@Maleclypse
Copy link
Member

Maleclypse commented Jan 18, 2025

How hard is it to change the name of the cash in the PCs account to something like UICA credits?

edit: maybe something that can be set in modinfo json?

@John-Candlebury
Copy link
Member Author

Presumambly not hard but the modsis already calling money "United Solar Denomination" in most places I noticed.

Probably just needs a consistency pass.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Aftershock Anything to do with the Aftershock mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aftershock: Unable to Buy Passage Planetside
2 participants